From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl_diu_fb: further refactoring of FLS DIU code
Date: Thu, 23 Sep 2010 18:38:43 +0200 [thread overview]
Message-ID: <20100923183843.14d6c317@wker> (raw)
In-Reply-To: <4C9B8111.9050509@freescale.com>
On Thu, 23 Sep 2010 11:32:17 -0500
Timur Tabi <timur@freescale.com> wrote:
> Anatolij Gustschin wrote:
> > This is the first patch version for testing on HW I do not
> > have (mpc8610hpcd, p1022ds). Tested on pdm360ng board.
> >
> > The patch will be modified to fix board config files as
> > needed in the final version. We probably should also move
> > fsl_diu_fb.c file to 'drivers/video'.
>
> This works, except the default should be CONFIG_VIDEO is undefined. It's
> unlikely the customer will have a monitor connected to the DVI port.
Ok, thanks.
> > +++ b/include/configs/MPC8610HPCD.h
> > @@ -22,7 +22,9 @@
> > #define CONFIG_FSL_DIU_FB 1 /* FSL DIU */
> >
> > /* video */
> > -#undef CONFIG_VIDEO
> > +#ifdef CONFIG_FSL_DIU_FB
> > +#define CONFIG_VIDEO
> > +#endif
>
> leave this undefined, and ...
Okay.
...
> > +++ b/include/configs/P1022DS.h
> > @@ -178,7 +178,7 @@
> > #define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
> >
> > /* Video */
> > -#undef CONFIG_FSL_DIU_FB
> > +#define CONFIG_FSL_DIU_FB
>
> don't make this change.
Yes. I enabled it for your test and will remove it.
Thanks,
Anatolij
next prev parent reply other threads:[~2010-09-23 16:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 16:46 [U-Boot] [PATCH] [v2] p1022ds: add video support Timur Tabi
2010-09-22 23:53 ` Anatolij Gustschin
2010-09-22 23:57 ` [U-Boot] [PATCH] fsl_diu_fb: further refactoring of FLS DIU code Anatolij Gustschin
2010-09-23 0:02 ` Anatolij Gustschin
2010-09-23 16:32 ` Timur Tabi
2010-09-23 16:38 ` Anatolij Gustschin [this message]
2010-09-24 5:27 ` [U-Boot] [PATCH v2 1/2] fsl_diu_fb: further refactoring of FSL " Anatolij Gustschin
2010-09-25 11:49 ` Anatolij Gustschin
2010-09-24 5:27 ` [U-Boot] [PATCH v2 2/2] p1022ds: add video support Anatolij Gustschin
2010-09-25 11:51 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923183843.14d6c317@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.