From: Chris Ball <cjb@laptop.org>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: linux-mmc@vger.kernel.org, Kyungmin Park <kmpark@infradead.org>
Subject: Re: [patch] sdhci: correct f_min in sd 3.0
Date: Fri, 24 Sep 2010 03:06:09 +0100 [thread overview]
Message-ID: <20100924020609.GA9901@void.printf.net> (raw)
In-Reply-To: <AANLkTimp+4V9zvQtOqHoVmpH-+Vmb+0Sr1MzM-cNHAiC@mail.gmail.com>
Hi,
On Mon, Sep 20, 2010 at 03:32:58AM -0400, zhangfei gao wrote:
> From: Zhangfei Gao <zhangfei.gao@marvell.com>
> Date: Mon, 20 Sep 2010 15:15:18 -0400
> Subject: [PATCH 4/4] sdhci: correct f_min in sd 3.0
>
> Change-Id: Ie8604dbb5296b15da67071164564f21c60652b60
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@marvell.com>
> ---
> drivers/mmc/host/sdhci.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index f980fb7..5346803 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1835,6 +1835,8 @@ int sdhci_add_host(struct sdhci_host *host)
> mmc->ops = &sdhci_ops;
> if (host->ops->get_min_clock)
> mmc->f_min = host->ops->get_min_clock(host);
> + else if (host->version >= SDHCI_SPEC_300)
> + mmc->f_min = host->max_clk / 2046;
> else
> mmc->f_min = host->max_clk / 256;
> mmc->f_max = host->max_clk;
Has anyone else tested this change? Looks correct, but it would be
nice to have a Tested-by or Acked-by on this.
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-09-24 2:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 7:32 [patch] sdhci: correct f_min in sd 3.0 zhangfei gao
2010-09-24 2:06 ` Chris Ball [this message]
2010-09-24 3:24 ` Chris Ball
2010-09-25 4:23 ` zhangfei gao
2010-09-28 3:13 ` Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2010-09-28 4:05 Philip Rakity
2010-09-28 4:58 ` zhangfei gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100924020609.GA9901@void.printf.net \
--to=cjb@laptop.org \
--cc=kmpark@infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.