Re: [E1000-eedc] [PATCH 05/10] implementation of VDP

[Jens Osterkamp <jens@linux.vnet.ibm.com>]

On Thursday 23 September 2010, John Fastabend wrote:
> On 8/25/2010 5:27 AM, Jens Osterkamp wrote:
> > This patch contains an initial implemention of VDP as specified in IEEE
> > 802.1Qbg.
> > VDP serves as the upper layer protocol (ULP) for TLVs communicated via the
> > ECP protocol.
> > For this it registers as a new module in lldpad. The VDP module supports a
> > station and a bridge role. As a station, new VSI (virtual station interface)
> > profiles can be registered to the VDP module using lldptool or libvirt.
> > These profiles are then announced to an adjacent switch. Transmitted profiles
> > are processed to the desired state by the VDP station state machine.
> > As a bridge, the VDP module waits for new profiles received in TLVs by ECP.
> > The received profiles are processed to the desired state by a VDP bridge
> > state machine.
> > 
> > VDP module parameters are stored in the "vdp" section under the appropriate
> > interface.
> > 
> > The patch still contains a lot of debug code to allow analysis of VDP
> > protocol behavior.
> > 
> > Signed-off-by: Jens Osterkamp <jens@linux.vnet.ibm.com>

snip

> 
> 
> Few minor nits otherwise looks good. Please merge relevant parts with patch 4 though.

I will address all your comments in my next posting of the series.

Thanks !

Jens

-- 

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294