Re: [PATCH 1/1] omap: fix section mismatch errors

[Tony Lindgren <tony@atomide.com>]

* Premi, Sanjeev <premi@ti.com> [100924 07:01]:
> > -----Original Message-----
> > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com] 
> > Sent: Friday, September 24, 2010 2:10 PM
> > To: ext Tony Lindgren
> > Cc: Premi, Sanjeev; linux-omap@vger.kernel.org
> > Subject: Re: [PATCH 1/1] omap: fix section mismatch errors
> > 
> > On Thu, 2010-09-23 at 18:36 +0200, ext Tony Lindgren wrote:
> > > * Sanjeev Premi <premi@ti.com> [100816 08:24]:
> > > > This patch fixes miltiple section mismatch errors
> > > > observed with the latest master.
> > > 
> > > Few comments below.
> > >  
> > > > @@ -134,7 +134,7 @@ static inline void board_smc91x_init(void)
> > > >  
> > > >  #endif
> > > >  
> > > > -static struct omap_board_config_kernel sdp2430_config[] = {
> > > > +static struct omap_board_config_kernel sdp2430_config[] 
> > __initdata = {
> > > >  	{OMAP_TAG_LCD, &sdp2430_lcd_config},
> > > >  };
> > > ...
> > >   
> > > Let's just get rid of omap_get_config stuff. The OMAP_TAG_LCD
> > > and OMAP_TAG_FBMEM are the last remaining legacy tags. They should
> > > be replaced with just platform_data. And while at it, it should
> > > be done for all the boards.
> > > 
> > > Tomi, do you see any problems with that?
> > 
> > OMAP_TAG_LCD and OMAP_TAG_FBMEM are used by the old omapfb driver.
> > 
> > I don't see any problem in changing them to platform data, except that
> > it's some work and somebody should do it =).
> > 
> >  Tomi
> > 
> Tony,
> 
> Can we do this as a separate patch? Or should I go down this path in
> same context?... it may delay this patch.

Sounds like a separate patch. But let's not create noise about
OMAP_TAG_LCD related warnings if we intent to remove them later on
anyways.

Tony