From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Fri, 24 Sep 2010 18:50:08 +0000 Subject: Re: [lm-sensors] x86/hwmon: fix module init for Message-Id: <20100924185008.GA20110@ericsson.com> List-Id: References: <4C8E139F0200007800015AA5@vpn.id2.novell.com> In-Reply-To: <4C8E139F0200007800015AA5@vpn.id2.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jan Beulich Cc: fenghua.yu@intel.com, khali@linux-fr.org, gong.chen@linux.intel.com, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org On Mon, Sep 13, 2010 at 10:05:51AM -0000, Jan Beulich wrote: > In commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae the call to > platform_driver_unregister() was made conditional upon !HOTPLUG_CPU, > but the return value from coretemp_init() was left to indicate an > error. This isn't correct, as the negative return value indicates to > the module loader that initialization failed, which isn't intended > here and results in dangling pointers. > > Signed-off-by: Jan Beulich > Cc: Chen Gong > Looks like my previous mail got lost or stuck in our e-mail system. Trying again. Sorry if this message is received twice. I have not seen an Acked-by for this set of patches, nor a Nack. Since (most of) the patches fix real bugs, I applied the ones which do into my staging tree, and the others into my -next tree. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757451Ab0IXSvG (ORCPT ); Fri, 24 Sep 2010 14:51:06 -0400 Received: from imr4.ericy.com ([198.24.6.8]:33310 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754319Ab0IXSvF (ORCPT ); Fri, 24 Sep 2010 14:51:05 -0400 Date: Fri, 24 Sep 2010 11:50:08 -0700 From: Guenter Roeck To: Jan Beulich CC: fenghua.yu@intel.com, khali@linux-fr.org, gong.chen@linux.intel.com, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: x86/hwmon: fix module init for hotplug-but-no-device-found case Message-ID: <20100924185008.GA20110@ericsson.com> References: <4C8E139F0200007800015AA5@vpn.id2.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4C8E139F0200007800015AA5@vpn.id2.novell.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 13, 2010 at 10:05:51AM -0000, Jan Beulich wrote: > In commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae the call to > platform_driver_unregister() was made conditional upon !HOTPLUG_CPU, > but the return value from coretemp_init() was left to indicate an > error. This isn't correct, as the negative return value indicates to > the module loader that initialization failed, which isn't intended > here and results in dangling pointers. > > Signed-off-by: Jan Beulich > Cc: Chen Gong > Looks like my previous mail got lost or stuck in our e-mail system. Trying again. Sorry if this message is received twice. I have not seen an Acked-by for this set of patches, nor a Nack. Since (most of) the patches fix real bugs, I applied the ones which do into my staging tree, and the others into my -next tree. Guenter