All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Manuel Lauss <manuel.lauss@googlemail.com>,
	linux-serial@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RESEND 1/2] 8250: pm callback for platform uarts
Date: Fri, 24 Sep 2010 16:41:11 -0700	[thread overview]
Message-ID: <20100924234111.GC20601@kroah.com> (raw)
In-Reply-To: <20100925005040.1a127135@lxorguk.ukuu.org.uk>

On Sat, Sep 25, 2010 at 12:50:40AM +0100, Alan Cox wrote:
> > > This bit makes sense - but why can't you simply propogate it to the
> > > existing uart_8250_port callback when registering ?
> > 
> > 
> > I need a hook for platform code to reenable the UART block clocks before
> > serial8250_set_sleep() is invoked on resume.  The current code actually
> > works, it's just that on resume the bootloader disables the clocks for
> > all UART blocks except the debug one, which leaves all others dead.
> > 
> > So I added the these calls into these platform methods around
> > serial8250_set_sleep().
> 
> Which isn't the right way to do this IMHO. It may work for your specific
> case but a solution needs to be generic.
> 
> The comment about sticking it in the wrong structd also holds.
> 
> So NAK this patch.

Ok, I'll go drop the two patches in this series from my tree.

thanks,

greg k-h

      reply	other threads:[~2010-09-24 23:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24 16:13 [PATCH RESEND 1/2] 8250: pm callback for platform uarts Manuel Lauss
2010-09-24 16:13 ` [PATCH RESEND 2/2] Alchemy: UART PM through serial framework Manuel Lauss
2010-09-24 17:22 ` [PATCH RESEND 1/2] 8250: pm callback for platform uarts Alan Cox
2010-09-24 17:15   ` Manuel Lauss
2010-09-24 23:50     ` Alan Cox
2010-09-24 23:41       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100924234111.GC20601@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-serial@vger.kernel.org \
    --cc=manuel.lauss@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.