From: Ted Ts'o <tytso@mit.edu>
To: Justin Maggard <jmaggard10@gmail.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: Broken e2fsck i_blocks repair
Date: Sat, 25 Sep 2010 08:24:03 -0400 [thread overview]
Message-ID: <20100925122403.GE9597@thunk.org> (raw)
In-Reply-To: <AANLkTinT3O20u-iE4Mu2ikSPa4bdhVsM+a82p6Hoeu8K@mail.gmail.com>
On Wed, Sep 01, 2010 at 04:01:22PM -0700, Justin Maggard wrote:
> I've mentioned this before on here, but I never verified whether or
> not it was actually broken. I have done so today. I manually
> modified the block count of a 3TB file using debugfs, then ran e2fsck
> on it. e2fsck claimed to repair it, but would throw an error on every
> subsequent e2fsck run for the same issue. The reason is
> inode->osd2.linux2.l_i_blocks_hi is always set to 0 if e2fsck is told
> to fix it. This is an issue in both stable 1.41.12, and in master.
> This patch fixes it for me, but is there anything else that needs to
> get checked here?
Sorry for the delay; September has been rather busy for me. This fix
has been checked in and pushed out to the e2fsprogs git repository.
I've taken a look and there doesn't seem to be any other places where
this mistake could have happened.
Thanks for pointing it out!
- Ted
prev parent reply other threads:[~2010-09-25 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 23:01 Broken e2fsck i_blocks repair Justin Maggard
2010-09-01 23:49 ` Andreas Dilger
2010-09-02 0:08 ` Eric Sandeen
2010-09-25 12:24 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100925122403.GE9597@thunk.org \
--to=tytso@mit.edu \
--cc=jmaggard10@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.