From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Venkatesh Pallipadi <venki@google.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] generic-ipi: fix deadlock in __smp_call_function_single
Date: Sun, 26 Sep 2010 10:42:33 +0200 [thread overview]
Message-ID: <20100926084233.GA28809@elte.hu> (raw)
In-Reply-To: <20100910172805.a4fe5c7f.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> Maybe. Or maybe it papers over a scheduler bug by gratuitously adding
> additional code which no present callsites actually need.
Hm, indeed.
We now have the scheduler bug fixed upstream. Do we really need this
patch?
> The patch didn't update the __smp_call_function_single() kerneldoc.
> Compare it with smp_call_function_single() and note the subtle
> difference between "a specific CPU" and the now incorrect "on another
> CPU".
In any case this feedback didnt get addressed AFAICS.
Ingo
next prev parent reply other threads:[~2010-09-26 8:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 13:50 [PATCH] generic-ipi: fix deadlock in __smp_call_function_single Heiko Carstens
2010-09-10 11:06 ` Peter Zijlstra
2010-09-10 11:23 ` Jens Axboe
2010-09-10 11:47 ` Heiko Carstens
2010-09-10 15:47 ` [tip:core/urgent] generic-ipi: Fix " tip-bot for Heiko Carstens
2010-09-11 0:28 ` [PATCH] generic-ipi: fix " Andrew Morton
2010-09-11 9:20 ` Peter Zijlstra
2010-09-11 16:42 ` Venkatesh Pallipadi
2010-09-13 8:08 ` Heiko Carstens
2010-09-13 18:02 ` Suresh Siddha
2010-09-14 8:03 ` Peter Zijlstra
2010-09-14 11:19 ` Heiko Carstens
2010-09-17 22:12 ` Suresh Siddha
2010-09-18 15:18 ` Peter Zijlstra
2010-09-21 14:13 ` [tip:sched/urgent] sched: Fix nohz balance kick tip-bot for Suresh Siddha
2010-09-26 8:42 ` Ingo Molnar [this message]
2010-09-26 12:59 ` [PATCH] generic-ipi: fix deadlock in __smp_call_function_single Heiko Carstens
2010-09-26 16:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926084233.GA28809@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=suresh.b.siddha@intel.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.