From: Chris Ball <cjb@laptop.org>
To: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
zhangfei gao <zhangfei.gao@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Saeed Bishara <saeed@marvell.com>
Subject: Re: [patch 2/2] mmc: add support of sdhci-pxa driver
Date: Sun, 26 Sep 2010 16:59:05 +0100 [thread overview]
Message-ID: <20100926155905.GB19772@void.printf.net> (raw)
In-Reply-To: <AANLkTimk2_KcmSAV-UZ3JY1JFD657SnfyPFgP_zE5bbP@mail.gmail.com>
On Sun, Sep 26, 2010 at 10:45:02PM +0800, Haojian Zhuang wrote:
> > I prefer we rename it to something like sdhci-mmp.c and the 'pxa' in the
> > source code to 'mmp' to cause less confusion with pxamci.c?
>
> Maybe sdhci-pxa.c is better. pxamci.c isn't compatible with sdhci, so
> it won't make people confusion.
The confusion can still happen when people are wondering which driver to
build for their SoC.
It seems that both names are confusing -- sdhci-mmp would confuse this
driver with the one submitted by Saeed Bishara for Dove/MMP, and
sdhci-pxa confuses it with pxamci.c.
Have you considered sdhci-mmp for Saeed's driver, and sdhci-mmp2 for
this driver? Or, sdhci-dove and sdhci-mmp2? Perhaps a non-exhaustive
distinction is better than an incorrectly generalized one.
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-09-26 15:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 10:56 [patch 2/2] mmc: add support of sdhci-pxa driver zhangfei gao
2010-09-26 12:39 ` Eric Miao
2010-09-26 14:45 ` Haojian Zhuang
2010-09-26 15:59 ` Chris Ball [this message]
2010-09-26 16:09 ` Haojian Zhuang
2010-09-26 17:48 ` Chris Ball
2010-09-27 1:36 ` Haojian Zhuang
2010-09-28 23:36 ` Chris Ball
2010-10-03 8:15 ` Saeed Bishara
2010-09-26 15:05 ` zhangfei gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926155905.GB19772@void.printf.net \
--to=cjb@laptop.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=saeed@marvell.com \
--cc=w.sang@pengutronix.de \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.