From: Jarod Wilson <jarod@redhat.com>
To: George Spelvin <linux@horizon.com>
Cc: linux-input@vger.kernel.org
Subject: Re: Hacking on ati_remote driver
Date: Sun, 26 Sep 2010 15:22:26 -0400 [thread overview]
Message-ID: <20100926192226.GA24012@redhat.com> (raw)
In-Reply-To: <20100923012720.14819.qmail@science.horizon.com>
On Wed, Sep 22, 2010 at 09:27:20PM -0400, George Spelvin wrote:
> I dusted off my ATI all-in-wonder remote and was trying to get it to
> work with VLC (so far unsuccessfully; I'm still untangling the
> multiple mapping layers between hardware scancode and X event), and
> I had a look at the ati_remote.c driver.
>
> I started hacking on it. Mostly I thought the ati_remote_tbl[]
> array was wastefully large. It gets a lot simpler when you
> realize that, in the 4-byte report, data[1] is actually a checksum
> and not part of the keycode. data[1] = data[2] + data[3] + 0xE5.
>
> Having looked over the input layer documentation, I have decided that
> the ati_remote driver could use some love. I'd like to convert it to
> use the generic scancode to keycode mapping and autorepeat logic.
IMO, ati_remote.c and ati_remote2.c should be adapted to use the ir-core
(soon to be rc-core) interfaces. I've got remote2 hardware myself, so
doing the conversion for that driver is already on my personal TODO list,
but its a long queue of more important things ahead of it first...
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2010-09-26 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 1:27 Hacking on ati_remote driver George Spelvin
2010-09-26 19:22 ` Jarod Wilson [this message]
2010-09-27 14:42 ` George Spelvin
2010-09-27 16:07 ` Jarod Wilson
2010-09-27 16:33 ` Mauro Carvalho Chehab
2010-09-28 19:04 ` George Spelvin
2010-09-28 20:00 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926192226.GA24012@redhat.com \
--to=jarod@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux@horizon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.