From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: xiaosuo@gmail.com, eric.dumazet@gmail.com,
socketcan@hartkopp.net, mst@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out
Date: Mon, 27 Sep 2010 05:30:47 +0000 [thread overview]
Message-ID: <20100927053046.GA6296@ff.dom.local> (raw)
In-Reply-To: <20100926.182208.102539866.davem@davemloft.net>
On Sun, Sep 26, 2010 at 06:22:08PM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Fri, 24 Sep 2010 06:36:23 +0000
>
> > af_packet could check some flag which guarantees the queued dev can do
> > skb_orphan after the real xmit and copy buffers otherwise.
>
> Jarek, we pre-orphan SKBs in the core way before device even gets
> the packet.
I'm not sure which place in the core do you mean; skb_orphan_try() in
dev_hard_start_xmit() depends on ->tx_flags.
Jarek P.
next prev parent reply other threads:[~2010-09-27 5:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 10:15 [PATCH v3] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out Changli Gao
2010-09-23 12:29 ` Eric Dumazet
2010-09-23 14:17 ` Changli Gao
2010-09-23 14:41 ` Eric Dumazet
2010-09-24 6:36 ` Jarek Poplawski
2010-09-24 7:01 ` Eric Dumazet
2010-09-27 1:25 ` David Miller
2010-09-27 5:40 ` Eric Dumazet
2010-09-27 1:22 ` David Miller
2010-09-27 5:30 ` Jarek Poplawski [this message]
2010-09-27 6:56 ` David Miller
2010-09-27 1:24 ` Changli Gao
2010-09-27 5:46 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927053046.GA6296@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.