From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH V2 2/2] mmc: sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case Date: Mon, 27 Sep 2010 16:02:18 +0100 Message-ID: <20100927150218.GB11578@void.printf.net> References: <1285576940-27587-1-git-send-email-matt@console-pimps.org> <1285576940-27587-3-git-send-email-matt@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:56325 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756234Ab0I0PCT (ORCPT ); Mon, 27 Sep 2010 11:02:19 -0400 Content-Disposition: inline In-Reply-To: <1285576940-27587-3-git-send-email-matt@console-pimps.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Matt Fleming Cc: Jaehoon Chung , linux-mmc@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Andrew Morton , Ben Hutchings , Yunpeng Gao , zhangfei gao Hi Matt, On Mon, Sep 27, 2010 at 09:42:20AM +0100, Matt Fleming wrote: > From: Jaehoon Chung > > When a controller requires SDHCI_QUIRK_BROKEN_CARD_DETECTION, we poll > for card insertion/removal, and that creates interrupts. There's no > need to be doing this if we have a non-removable card. > > This patch requires cards to be removable before we're willing to set > MMC_CAP_NEEDS_POLL. > > Signed-off-by: Jaehoon Chung > Acked-by: Kyungmin Park > Acked-by: Matt Fleming > [cjb: modified changelog and code indentation] > Signed-off-by: Chris Ball Thanks, applied to mmc-next with Wolfram's ACK. - Chris. -- Chris Ball One Laptop Per Child