All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Kevin Ballard <kevin@sb.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] merge-recursive: option to specify rename threshold
Date: Mon, 27 Sep 2010 18:53:55 -0500	[thread overview]
Message-ID: <20100927235355.GG11957@burratino> (raw)
In-Reply-To: <FFDB2371-6C96-472C-A650-412546636450@sb.org>

Kevin Ballard wrote:

> After taking a look at this, it raises another question. -B, -M, and
> -C all have optional arguments, but the long-form names don't seem
> to support that.
[...]
>                       if I make it support `git diff
> --rename-threshold foo` that would also work, but the name doesn't
> seem appropriate without the argument.

Right --- with merge-recursive the argument doesn't need to be
optional, but with git diff it does.

How about

	--detect-renames=<threshold>
	--detect-copies=<threshold>
	--detect-rewrites=<threshold>/<threshold>

?

Ciao,
Jonathan

  reply	other threads:[~2010-09-27 23:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22  6:03 [WIP/PATCH] merge-recursive: option to specify rename threshold Kevin Ballard
2010-09-23  0:32 ` [PATCH] " Kevin Ballard
2010-09-23  0:38   ` Kevin Ballard
2010-09-23  0:45     ` Kevin Ballard
2010-09-27  4:11       ` Junio C Hamano
2010-09-27  5:04         ` Kevin Ballard
2010-09-27  5:24           ` Junio C Hamano
2010-09-27  5:34             ` Kevin Ballard
2010-09-27  6:04               ` Junio C Hamano
2010-09-27 22:01             ` Kevin Ballard
2010-09-27 23:53               ` Jonathan Nieder [this message]
2010-09-28  0:01                 ` Kevin Ballard
2010-09-28  0:08                   ` Jonathan Nieder
2010-09-28  0:14                     ` Kevin Ballard
2010-09-28  0:24                       ` Jonathan Nieder
2010-09-27 23:58               ` [PATCHv2 1/2] " Kevin Ballard
2010-09-27 23:58               ` [PATCHv2 2/2] diff: add synonyms for -M, -C, -B Kevin Ballard
2010-09-28 21:15                 ` Thell Fowler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100927235355.GG11957@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kevin@sb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.