From: "Jan Krüger" <jk@jk.gs>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git ML <git@vger.kernel.org>, Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH] repack: add -F option that passes --no-reuse-delta to pack-objects
Date: Tue, 28 Sep 2010 08:44:51 +0200 [thread overview]
Message-ID: <20100928084451.78c13d17@jk.gs> (raw)
In-Reply-To: <7vbp7j2krn.fsf@alter.siamese.dyndns.org>
--- Junio C Hamano <gitster@pobox.com> wrote:
> Jan Krüger <jk@jk.gs> writes:
>
> > Discussion point: it might make more sense to switch the meanings
> > around, making -F do the 'bigger' routine and reverting -f to what
> > it used to be. I don't feel strongly about that, however.
>
> That sounds sensible. reuse_object is used only to z-recompress and
> is not involved in precomputed delta selection, and under normal
> circumstances it should not have much effect on the outcome.
>
> Please make it so.
Already done. See the alternative patch (in a 2-series) at
20100927141936.590d71b3@jk.gs
<http://mid.gmane.org/20100927141936.590d71b3@jk.gs>. I Cc'd you and
Nicolas acked it. Just saying. ;-)
-Jan
next prev parent reply other threads:[~2010-09-28 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 11:31 [PATCH] repack: add -F option that passes --no-reuse-delta to pack-objects Jan Krüger
2010-09-27 11:53 ` Nicolas Pitre
2010-09-27 12:19 ` [Alt. PATCH 1/2] repack: add -F flag to let user choose between --no-reuse-delta/object Jan Krüger
2010-09-27 12:21 ` [Alt. PATCH 2/2] Documentation: pack.compression: explain how to recompress Jan Krüger
2010-09-27 14:10 ` Nicolas Pitre
2010-09-27 14:10 ` [Alt. PATCH 1/2] repack: add -F flag to let user choose between --no-reuse-delta/object Nicolas Pitre
2010-09-27 16:50 ` [PATCH] repack: add -F option that passes --no-reuse-delta to pack-objects Junio C Hamano
2010-09-28 6:44 ` Jan Krüger [this message]
2010-09-28 9:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928084451.78c13d17@jk.gs \
--to=jk@jk.gs \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.