From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Philip Rakity <prakity@marvell.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [RFC] remove quirk for broken clock - redundant since ops->max_clock defined
Date: Tue, 28 Sep 2010 15:11:05 +0400 [thread overview]
Message-ID: <20100928111105.GA20742@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <23CB1625-7451-41BD-AD43-73C588A1593F@marvell.com>
On Tue, Sep 28, 2010 at 12:39:47AM -0700, Philip Rakity wrote:
>
> >From 2b436be109ad004e94a2b63f71f6bb8e00f9d3da Mon Sep 17 00:00:00 2001
> From: Philip Rakity <prakity@marvell.com>
> Date: Tue, 28 Sep 2010 00:34:17 -0700
> Subject: [RFC] remove quirk for broken clock - redundant since ops->max_clock defined
>
> Are we okay moving in this direction? Patch is NOT tested since RFC -- does compile.
>
> If we are moving away from using both quirks and host->ops to define
> platform specific actions -- just use the host->ops operation to
> get max_clock.
Again, I can only cite Pierre Ossman:
On Sun, Feb 08, 2009 at 10:04:40PM +0100, Pierre Ossman wrote:
| As I told Ben, I prefer if we stick to the standard as much as
| possible. So no external info unless the register is set to zero.
Your patch breaks that rule. Other than that, technically it
looks OK.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2010-09-28 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 4:05 [patch] sdhci: correct f_min in sd 3.0 Philip Rakity
2010-09-28 4:58 ` zhangfei gao
2010-09-28 7:39 ` [RFC] remove quirk for broken clock - redundant since ops->max_clock defined Philip Rakity
2010-09-28 11:11 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928111105.GA20742@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.