From: Anton Vorontsov <cbouatmailru@gmail.com>
To: "Richard A. Smith" <richard@laptop.org>
Cc: Daniel Drake <dsd@laptop.org>,
dwmw2@infradead.org, dilinger@queued.net,
linux-kernel@vger.kernel.org, harvey.harrison@gmail.com
Subject: Re: [PATCH v2] olpc_battery: Fix endian neutral breakage for s16 values
Date: Tue, 28 Sep 2010 15:16:07 +0400 [thread overview]
Message-ID: <20100928111607.GA22734@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4CA0AF77.1080105@laptop.org>
On Mon, Sep 27, 2010 at 10:51:35AM -0400, Richard A. Smith wrote:
> On 09/25/2010 02:19 PM, Daniel Drake wrote:
> >From: Richard A. Smith<richard@laptop.org>
> >
> >When the driver was updated to be endian neutral (8e9c7716c)
> >the signed part of the s16 values was lost. This is because be16_to_cpu()
> >returns a signed value. This patch casts the values back to a s16 number
> >prior to the the implicit cast up to an int.
>
> Seems the comment has a error. Should be 'returns an unsigned'
> rather than signed. Other than that it looks good.
Fixed and applied w/ Cc: <stable@kernel.org>, thanks!
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2010-09-28 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 18:19 [PATCH v2] olpc_battery: Fix endian neutral breakage for s16 values Daniel Drake
2010-09-27 14:51 ` Richard A. Smith
2010-09-28 11:16 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928111607.GA22734@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=dwmw2@infradead.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.