All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc5xxx_fec: add call to reset_phy() after PHY initialization
Date: Tue, 28 Sep 2010 19:44:50 +0200	[thread overview]
Message-ID: <20100928174450.DBAFFD52190@gemini.denx.de> (raw)
In-Reply-To: <20100913093325.A8A8415242D@gemini.denx.de>

Dear Ben,

ping again...

In message <20100913093325.A8A8415242D@gemini.denx.de> I wrote:
> Dear Ben,
> 
> In message <1282208946-18823-1-git-send-email-yanok@emcraft.com> Ilya Yanok wrote:
> > Some boards need their board-specific PHY quirks to be called
> > to PHY to work normally. As mpc5xxx_fec driver uses on demand
> > PHY initialization and can even reinit PHY during normal operation
> > we can't count on reset_phy() call from arch/<arch>/lib/board.c
> > (it is most likely called _before_ we init the PHY from the
> > driver) so we need to add call to reset_phy() directly in the
> > driver.
> > 
> > Cc: Ben Warren <biggerbadderben@gmail.com>
> > Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> > ---
> >  drivers/net/mpc5xxx_fec.c |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> Do you have any comments?


Please comment how to go on - this is a real problem that needs to be
fixed one way or another.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is more rational to sacrifice one life than six.
	-- Spock, "The Galileo Seven", stardate 2822.3

  reply	other threads:[~2010-09-28 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19  9:09 [U-Boot] [PATCH] mpc5xxx_fec: add call to reset_phy() after PHY initialization Ilya Yanok
2010-09-13  9:33 ` Wolfgang Denk
2010-09-28 17:44   ` Wolfgang Denk [this message]
2010-10-12  6:11 ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100928174450.DBAFFD52190@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.