All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexander Stohr" <Alexander.Stohr@gmx.de>
To: openembedded-devel@lists.openembedded.org
Cc: automake-patches@gnu.org
Subject: [patch] cross keyword for automake warnings
Date: Tue, 28 Sep 2010 19:45:41 +0200	[thread overview]
Message-ID: <20100928174541.200740@gmx.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

each of the following two patches adds the "cross" keyword to the command line option --warnings of the automake utility.

that feature is merely a dummy right now as it's not yet used by the tool.
it improves consistency for the commandline parameters of the tools from that sector.
it further helps the oe build to not fail when e.g. a tool from the
autoconf collection blindly tries to pass along "--warnings=cross" to automake.

consider this as a systematic change that paves the way for more whilst reducing need for complexity (like filtering that) in the callers area.

two versions are appended.
i only ran the one for 1.10.x on my build testbed.

regards, Alex.
-- 
GRATIS: Spider-Man 1-3 sowie 300 weitere Videos!
Jetzt freischalten! http://portal.gmx.net/de/go/maxdome

[-- Attachment #2: automake-1.10.2.cross-warnings-001.patch --]
[-- Type: text/x-patch, Size: 1684 bytes --]

diff -usbr automake-1.10.2.orig/aclocal.in automake-1.10.2/aclocal.in
--- automake-1.10.2.orig/aclocal.in	2008-11-23 09:28:59.000000000 +0100
+++ automake-1.10.2/aclocal.in	2010-09-28 18:55:24.000000000 +0200
@@ -887,6 +887,7 @@
   -W, --warnings=CATEGORY   report the warnings falling in CATEGORY
 
 Warning categories include:
+  `cross'         cross compilation issues
   `syntax'        dubious syntactic constructs (default)
   `unsupported'   unknown macros (default)
   `all'           all the warnings (default)
diff -usbr automake-1.10.2.orig/lib/Automake/ChannelDefs.pm automake-1.10.2/lib/Automake/ChannelDefs.pm
--- automake-1.10.2.orig/lib/Automake/ChannelDefs.pm	2008-11-23 09:28:59.000000000 +0100
+++ automake-1.10.2/lib/Automake/ChannelDefs.pm	2010-09-28 18:57:37.000000000 +0200
@@ -90,6 +90,10 @@
 
 Internal errors.  Use C<&prog_error> to send messages over this channel.
 
+=item C<cross>
+
+cross compilation issues
+
 =item C<gnu>
 
 Warnings related to GNU Coding Standards.
@@ -142,6 +146,7 @@
 	     "####################\n"),
   footer => "\nPlease contact <bug-automake\@gnu.org>.";
 
+register_channel 'cross', type => 'warning';
 register_channel 'gnu', type => 'warning';
 register_channel 'obsolete', type => 'warning', silent => 1;
 register_channel 'override', type => 'warning', silent => 1;
@@ -165,6 +170,7 @@
 sub usage ()
 {
   print "Warning categories include:
+  `cross'         cross compilation issues
   `gnu'           GNU coding standards (default in gnu and gnits modes)
   `obsolete'      obsolete features or constructions
   `override'      user redefinitions of Automake rules or variables

[-- Attachment #3: automake-1.11.1.cross-warnings-001.patch --]
[-- Type: text/x-patch, Size: 2198 bytes --]

diff -usbr automake-1.11.1.orig/aclocal.in automake-1.11.1/aclocal.in
--- automake-1.11.1.orig/aclocal.in	2009-12-08 19:02:32.000000000 +0100
+++ automake-1.11.1/aclocal.in	2010-09-28 18:42:26.000000000 +0200
@@ -890,6 +890,7 @@
   -W, --warnings=CATEGORY   report the warnings falling in CATEGORY
 
 Warning categories include:
+  `cross'         cross compilation issues
   `syntax'        dubious syntactic constructs (default)
   `unsupported'   unknown macros (default)
   `all'           all the warnings (default)
diff -usbr automake-1.11.1.orig/doc/aclocal-1.11.1 automake-1.11.1/doc/aclocal-1.11.1
--- automake-1.11.1.orig/doc/aclocal-1.11.1	2009-12-08 19:15:56.000000000 +0100
+++ automake-1.11.1/doc/aclocal-1.11.1	2010-09-28 18:42:59.000000000 +0200
@@ -47,6 +47,9 @@
 report the warnings falling in CATEGORY
 .SS "Warning categories include:"
 .TP
+`cross'
+cross compilation issues
+.TP
 `syntax'
 dubious syntactic constructs (default)
 .TP
diff -usbr automake-1.11.1.orig/lib/Automake/ChannelDefs.pm automake-1.11.1/lib/Automake/ChannelDefs.pm
--- automake-1.11.1.orig/lib/Automake/ChannelDefs.pm	2009-12-08 19:06:45.000000000 +0100
+++ automake-1.11.1/lib/Automake/ChannelDefs.pm	2010-09-28 18:46:22.000000000 +0200
@@ -150,6 +150,7 @@
   footer => "\nPlease contact <bug-automake\@gnu.org>.",
   uniq_part => UP_NONE, ordered => 0;
 
+register_channel 'cross', type => 'warning';
 register_channel 'gnu', type => 'warning';
 register_channel 'obsolete', type => 'warning', silent => 1;
 register_channel 'override', type => 'warning', silent => 1;
@@ -175,6 +176,7 @@
 sub usage ()
 {
   print "Warning categories include:
+  `cross'         cross compilation issues
   `gnu'           GNU coding standards (default in gnu and gnits modes)
   `obsolete'      obsolete features or constructions
   `override'      user redefinitions of Automake rules or variables
@@ -262,7 +264,11 @@
       $has_no = 1;
     }
 
-  if ($cat eq 'all')
+  if ($cat eq 'cross')
+    {
+      setup_channel_type 'warning', silent => $has_no;
+    }
+  elsif ($cat eq 'all')
     {
       setup_channel_type 'warning', silent => $has_no;
     }

             reply	other threads:[~2010-09-28 17:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 17:45 Alexander Stohr [this message]
2010-09-29 21:50 ` [patch] cross keyword for automake warnings Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100928174541.200740@gmx.net \
    --to=alexander.stohr@gmx.de \
    --cc=automake-patches@gnu.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.