From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Jouni Malinen <j@w1.fi>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"stable@kernel.org" <stable@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Paul Stewart <pstew@google.com>,
Amod Bodas <Amod.Bodas@Atheros.com>,
Johannes Berg <johannes@sipsolutions.net>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>
Subject: Re: [PATCH] mac80211: fix rate_control_send_low warnings for delbas
Date: Wed, 29 Sep 2010 10:50:06 +0530 [thread overview]
Message-ID: <20100929052006.GC18450@vasanth-laptop> (raw)
In-Reply-To: <AANLkTimGPPUW6=QYpZz7q96vt1GOd5kJ-tvYEKxZZT2B@mail.gmail.com>
On Wed, Sep 29, 2010 at 05:28:35AM +0530, Luis R. Rodriguez wrote:
> On Tue, Sep 28, 2010 at 4:02 PM, Jouni Malinen <j@w1.fi> wrote:
> > On Tue, Sep 28, 2010 at 03:29:45PM -0700, Luis R. Rodriguez wrote:
> >
> >> Added support for cfg80211/mac80211 to cleanly roam between two BSSes
> >> on an ESS by allowing the station to reassociate to an old AP and
> >> only when that is done drop the old association. What we forgot to
> >> take into consideration is that when we disassociate with the older
> >> AP we may need to transmit frames to that AP and those frames may
> >> actually be intended to go under a different channel and even sometimes
> >> a completely separate band than the new APs.
> >
> > which frames are you talking about here?
>
> ieee80211_send_delba()
>
> > When reassociating to a new BSS
> > in an ESS, there should be no need to transmit frames to the old AP
> > anymore, i.e., we are never associated with more than one BSS (when
> > talking about a single vif). We could just drop any potential TX frame
> > to the old AP after the moment the new AP is marked associated.
>
> That's the goal of this patch.
>From my debugging, this happens when cleaning up BA session for old
AP but on a different channel (where we just authenticated with
another AP) just before starting association with the new AP.
Though local->work_work takes care of moving to right channel,
it is possible that cfg80211 receives NL80211_CMD_ASSOCIATE before
local->work_work configures the hw back to old AP's channel (that
is what happening in our case).
Vasanth
next prev parent reply other threads:[~2010-09-29 5:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 22:29 [PATCH] mac80211: fix rate_control_send_low warnings for delbas Luis R. Rodriguez
2010-09-28 23:02 ` Jouni Malinen
2010-09-28 23:58 ` Luis R. Rodriguez
2010-09-29 5:20 ` Vasanthakumar Thiagarajan [this message]
2010-09-29 7:24 ` Luis R. Rodriguez
2010-09-29 8:56 ` Vasanthakumar Thiagarajan
2010-09-29 17:16 ` Luis R. Rodriguez
2010-09-29 17:24 ` Johannes Berg
2010-09-29 8:18 ` Johannes Berg
2010-09-29 17:10 ` Luis R. Rodriguez
2010-09-29 17:25 ` Johannes Berg
2010-09-30 17:53 ` Luis R. Rodriguez
2010-10-01 20:07 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929052006.GC18450@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Amod.Bodas@Atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=pstew@google.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.