From: Arnd Bergmann <arnd@arndb.de>
To: Petr Vandrovec <petr@vandrovec.name>
Cc: linux-fsdevel@vger.kernel.org, aia21@cam.ac.uk,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] Remove BKL usage from ncpfs
Date: Wed, 29 Sep 2010 14:31:54 +0200 [thread overview]
Message-ID: <201009291431.54709.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTinhD+P8y3BwNxro9fVr62MmASTubrefP9=Z8ce4@mail.gmail.com>
On Monday 27 September 2010, Petr Vandrovec wrote:
> Yes, I believe it is not necessary. fill_super(sb) should not run
> concurrently with anything else because MS_BORN and MS_ACTIVE are not
> set yet so nobody else should use this sb from VFS. One thing which
> seems to be missing is doing lock_sock() around code which sets
> sk->sk_{error_report,data_ready,write_space} - there does not seem to
> be anything else to protect ipv4/ipv6/ipx from seeing partially
> updated pointers on systems where these writes are not atomic - that's
> ncpfs2.patch.
>
> Also I found some whitespace problems, and one missing const, so if
> you could merge ncpfs3.patch & ncpfs4.patch with original BKL removal,
> it would be cool. Or I can resend all 4 patches as one bigger diff if
> you prefer.
Generally I prefer separate patches for changes that make sense to be
split, so I left ncpfs2.patch separately.
I think it would be nice to do the first patch in smaller steps, but
since you are the maintainer, I'm not going to complain ;-)
Applied both patches to my bkl/vfs series now.
Arnd
prev parent reply other threads:[~2010-09-29 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 23:47 [PATCH] Remove BKL usage from ncpfs Petr Vandrovec
2010-09-27 14:16 ` Arnd Bergmann
2010-09-27 17:51 ` Petr Vandrovec
2010-09-29 12:31 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009291431.54709.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=aia21@cam.ac.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petr@vandrovec.name \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.