From: Olof Johansson <olof@lixom.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] dmi: export dmi data through debugfs
Date: Wed, 29 Sep 2010 09:53:30 -0500 [thread overview]
Message-ID: <20100929145330.GA9351@lixom.net> (raw)
In-Reply-To: <20100929093403.7db92388@endymion.delvare>
On Wed, Sep 29, 2010 at 09:34:03AM +0200, Jean Delvare wrote:
> Hi Olaf,
>
> On Tue, 28 Sep 2010 16:12:46 -0500, Olof Johansson wrote:
> > I've found this quite useful since it allows dmidecode to run without
> > root privileges using --from-dump to read this file instead
>
> This is a bad idea. We do NOT want every user to have access to all the
> DMI information. There is sensitive information in there (serial
> numbers and UUIDs, and possibly even more sensitive data in
> OEM-specific records.) If you look in /sys/class/dmi/id/, you'll see
> that files board_serial, chassis_serial, product_serial and
> product_uuid are only readable by root exactly for this reason.
> So this is a NACK from me, sorry.
So how about a change to mode 0400 on the debugfs file then? It's
still better than having a userspace tool dig around /dev/mem for the
information.
-Olof
next prev parent reply other threads:[~2010-09-29 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 21:12 [PATCH] dmi: export dmi data through debugfs Olof Johansson
2010-09-29 7:34 ` Jean Delvare
2010-09-29 14:53 ` Olof Johansson [this message]
2010-09-29 15:11 ` Jean Delvare
2010-09-29 21:28 ` Alan Cox
2010-09-30 6:36 ` Jean Delvare
2010-09-30 14:31 ` Olof Johansson
2010-09-30 17:34 ` Andi Kleen
2010-09-30 17:59 ` Jean Delvare
2010-09-30 15:32 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929145330.GA9351@lixom.net \
--to=olof@lixom.net \
--cc=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.