From: "J. Bruce Fields" <bfields@fieldses.org>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (Was: linux-next: build warning after merge of the final tree)
Date: Wed, 29 Sep 2010 12:30:55 -0400 [thread overview]
Message-ID: <20100929163055.GC17087@fieldses.org> (raw)
In-Reply-To: <4CA322DA.90705@parallels.com>
On Wed, Sep 29, 2010 at 03:28:26PM +0400, Pavel Emelyanov wrote:
> > This actually causes a build failure on a sparc32 defconfig build:
> >
> > `rpcauth_remove_module' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o
> >
> > I applied the following patch for today:
> >
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 29 Sep 2010 14:07:07 +1000
> > Subject: [PATCH] sunrpc: fix up section mismatch
> >
> > Fixes:
> >
> > `rpcauth_remove_module' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Oops :(
>
> Acked-by: Pavel Emelyanov <xemul@openvz.org>
Thanks, applied, and I'll push that out soon.
--b.
>
> > ---
> > include/linux/sunrpc/auth.h | 4 ++--
> > net/sunrpc/auth.c | 2 +-
> > net/sunrpc/auth_generic.c | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/include/linux/sunrpc/auth.h b/include/linux/sunrpc/auth.h
> > index 5bbc447..b202475 100644
> > --- a/include/linux/sunrpc/auth.h
> > +++ b/include/linux/sunrpc/auth.h
> > @@ -122,8 +122,8 @@ extern const struct rpc_authops authnull_ops;
> > int __init rpc_init_authunix(void);
> > int __init rpc_init_generic_auth(void);
> > int __init rpcauth_init_module(void);
> > -void __exit rpcauth_remove_module(void);
> > -void __exit rpc_destroy_generic_auth(void);
> > +void rpcauth_remove_module(void);
> > +void rpc_destroy_generic_auth(void);
> > void rpc_destroy_authunix(void);
> >
> > struct rpc_cred * rpc_lookup_cred(void);
> > diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
> > index e9eaaf7..2c0d9e6 100644
> > --- a/net/sunrpc/auth.c
> > +++ b/net/sunrpc/auth.c
> > @@ -658,7 +658,7 @@ out1:
> > return err;
> > }
> >
> > -void __exit rpcauth_remove_module(void)
> > +void rpcauth_remove_module(void)
> > {
> > rpc_destroy_authunix();
> > rpc_destroy_generic_auth();
> > diff --git a/net/sunrpc/auth_generic.c b/net/sunrpc/auth_generic.c
> > index 43162bb..e010a01 100644
> > --- a/net/sunrpc/auth_generic.c
> > +++ b/net/sunrpc/auth_generic.c
> > @@ -158,7 +158,7 @@ int __init rpc_init_generic_auth(void)
> > return rpcauth_init_credcache(&generic_auth);
> > }
> >
> > -void __exit rpc_destroy_generic_auth(void)
> > +void rpc_destroy_generic_auth(void)
> > {
> > rpcauth_destroy_credcache(&generic_auth);
> > }
>
prev parent reply other threads:[~2010-09-29 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 4:02 linux-next: build warning after merge of the final tree Stephen Rothwell
2010-09-29 4:16 ` linux-next: build failure after merge of the final tree (Was: linux-next: build warning after merge of the final tree) Stephen Rothwell
2010-09-29 11:28 ` Pavel Emelyanov
2010-09-29 16:30 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929163055.GC17087@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.