From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Oliver Neukum <oliver@neukum.org>,
greg@kroah.com, linux-usb@vger.kernel.org,
linux-scsi@vger.kernel.org, sarah.a.sharp@linux.intel.com,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH 2/2] Add UAS driver
Date: Thu, 30 Sep 2010 08:04:05 +0200 [thread overview]
Message-ID: <201009300804.11861.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20100929005413.GB4689@linux.intel.com>
[-- Attachment #1: Type: Text/Plain, Size: 737 bytes --]
Matthew Wilcox wrote:
> On Tue, Sep 28, 2010 at 03:13:53PM +0200, Oliver Neukum wrote:
> > Am Dienstag, 28. September 2010, 12:14:56 schrieb Matthew Wilcox:
> > > + cmnd->result = sense_iu->status;
> > > + if (sdev->current_cmnd)
> > > + sdev->current_cmnd = NULL;
> >
> > the condition is absolutely senseless
>
> That's not true. Avoiding dirtying a cacheline is important for
> performance.
Go and tell your processor division to only mark a cacheline as dirty if it
was actually changed by a write. They are throwing so much resources on things
like SSE9 and the hell that they can probably afford doing that sort of
optimizations. Or they already do and this condition is absolutely senseless
;)
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-09-30 6:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 10:14 [PATCH 1/2] Move USB Storage definitions to their own header file Matthew Wilcox
2010-09-28 10:14 ` [PATCH 2/2] Add UAS driver Matthew Wilcox
[not found] ` <1285668896-6356-2-git-send-email-willy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-28 13:13 ` Oliver Neukum
2010-09-29 0:54 ` Matthew Wilcox
2010-09-29 4:47 ` Sarah Sharp
[not found] ` <20100929005413.GB4689-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-29 20:20 ` Oliver Neukum
2010-09-30 6:04 ` Rolf Eike Beer [this message]
2010-09-28 13:41 ` David Vrabel
2010-09-29 0:55 ` Matthew Wilcox
2010-09-29 3:30 ` David Brownell
2010-09-28 17:51 ` Matthew Dharm
2010-09-28 18:11 ` Greg KH
2010-09-28 18:52 ` Matthew Dharm
2010-09-29 1:56 ` Greg KH
[not found] ` <20100928175122.GE25677-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org>
2010-09-29 1:01 ` Matthew Wilcox
2010-09-29 2:08 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009300804.11861.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=greg@kroah.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=oliver@neukum.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.