All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: pavan_savoy@ti.com
Cc: gregkh@suse.de, alan@lxorguk.ukuu.org.uk,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging:ti-st: mv ti_wilink_st header
Date: Thu, 30 Sep 2010 04:51:23 -0700	[thread overview]
Message-ID: <20100930115123.GB2779@kroah.com> (raw)
In-Reply-To: <1285777522-13709-1-git-send-email-pavan_savoy@ti.com>

On Wed, Sep 29, 2010 at 12:25:22PM -0400, pavan_savoy@ti.com wrote:
> From: Pavan Savoy <pavan_savoy@ti.com>
> 
> Greg,
> 
> How is the movement of drivers done out of staging?
> Should I submit patches like these, which move individual files without
> breaking the build during anytime of movement?

Yes.

> In few following days I plan to submit patches to move the ST headers sources
> out.
> ti_wilink_st.h -> include/linux/
> st_core.c, st_kim.c and st_ll.c -> drivers/misc/
> Makefile and Kconfig changes to drivers/misc/Kconfig and drivers/misc/Makefile
> bt_drv.c -> drivers/bluetooth/

Yes, that sounds great.

But, the bluetooth patch should go to the bluetooth maintainer for his
review, I'll need the ack from him before I can apply it.

Oh, this patch looks nice, but I found one problem:

> --- a/drivers/staging/ti-st/ti_wilink_st.h
> +++ /dev/null
> -#ifndef TI_WILINK_ST_H
> -#define TI_WILINK_ST_H
> -
> -/* TODO:
> - * Move the following to tty.h upon acceptance
> - */
> -#define N_TI_WL	22	/* Ldisc for TI's WL BT, FM, GPS combo chips */

We need to do that now, before you move this file.

Then, you can drop this:

> -#ifdef __KERNEL__

As it will not be needed, right?

Care to send me a patch that does this first?

thanks,

greg k-h

  reply	other threads:[~2010-09-30 17:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29 16:25 [PATCH] drivers:staging:ti-st: mv ti_wilink_st header pavan_savoy
2010-09-30 11:51 ` Greg KH [this message]
2010-09-30 17:33   ` Savoy, Pavan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100930115123.GB2779@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavan_savoy@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.