From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ey0-f177.google.com ([209.85.215.177]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P1KiX-0000RL-KS for linux-mtd@lists.infradead.org; Thu, 30 Sep 2010 15:06:42 +0000 Received: by eye22 with SMTP id 22so946274eye.36 for ; Thu, 30 Sep 2010 08:06:40 -0700 (PDT) Date: Thu, 30 Sep 2010 19:06:33 +0400 From: Anton Vorontsov To: Grant Likely Subject: Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page Message-ID: <20100930150633.GA13741@oksana.dev.rtsoft.ru> References: <841976.76219.qm@web180306.mail.gq1.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: kumar.gala@freescale.com, David Brownell , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, spi-devel-general@lists.sourceforge.net, Mingkai Hu List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Sep 30, 2010 at 11:41:40PM +0900, Grant Likely wrote: > On Thu, Sep 30, 2010 at 11:16 PM, Grant Likely > wrote: > > On Thu, Sep 30, 2010 at 7:46 PM, David Brownell wrote: > >> > >> --- On Thu, 9/30/10, Mingkai Hu wrote: > >> > >>> From: Mingkai Hu > >>> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page > >> > >> NAK. > >> > >> We went over this before. > > > > Yes, I agree with David on this.  If large transfers don't work, then > > it is the SPI master driver that is buggy. > > By the way, does this fix your problem? > > https://patchwork.kernel.org/patch/184752/ It shouldn't. AFAIK, eSPI is PIO-only controller, and the overrun fix is for the DMA mode. Thanks, p.s. Btw, in patch 3/7, is_dma_mapped argument of fsl_espi_bufs() is unneeded. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page Date: Thu, 30 Sep 2010 19:06:33 +0400 Message-ID: <20100930150633.GA13741@oksana.dev.rtsoft.ru> References: <841976.76219.qm@web180306.mail.gq1.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: kumar.gala@freescale.com, David Brownell , linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, spi-devel-general@lists.sourceforge.net, Mingkai Hu To: Grant Likely Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org List-Id: linux-spi.vger.kernel.org T24gVGh1LCBTZXAgMzAsIDIwMTAgYXQgMTE6NDE6NDBQTSArMDkwMCwgR3JhbnQgTGlrZWx5IHdy b3RlOgo+IE9uIFRodSwgU2VwIDMwLCAyMDEwIGF0IDExOjE2IFBNLCBHcmFudCBMaWtlbHkKPiA8 Z3JhbnQubGlrZWx5QHNlY3JldGxhYi5jYT4gd3JvdGU6Cj4gPiBPbiBUaHUsIFNlcCAzMCwgMjAx MCBhdCA3OjQ2IFBNLCBEYXZpZCBCcm93bmVsbCA8ZGF2aWQtYkBwYWNiZWxsLm5ldD4gd3JvdGU6 Cj4gPj4KPiA+PiAtLS0gT24gVGh1LCA5LzMwLzEwLCBNaW5na2FpIEh1IDxNaW5na2FpLmh1QGZy ZWVzY2FsZS5jb20+IHdyb3RlOgo+ID4+Cj4gPj4+IEZyb206IE1pbmdrYWkgSHUgPE1pbmdrYWku aHVAZnJlZXNjYWxlLmNvbT4KPiA+Pj4gU3ViamVjdDogW1BBVENIIHYzIDYvN10gbXRkOiBtMjVw ODA6IGFkZCBhIHJlYWQgZnVuY3Rpb24gdG8gcmVhZCBwYWdlIGJ5IHBhZ2UKPiA+Pgo+ID4+IE5B Sy4KPiA+Pgo+ID4+IFdlIHdlbnQgb3ZlciB0aGlzIGJlZm9yZS4KPiA+Cj4gPiBZZXMsIEkgYWdy ZWUgd2l0aCBEYXZpZCBvbiB0aGlzLiDCoElmIGxhcmdlIHRyYW5zZmVycyBkb24ndCB3b3JrLCB0 aGVuCj4gPiBpdCBpcyB0aGUgU1BJIG1hc3RlciBkcml2ZXIgdGhhdCBpcyBidWdneS4KPiAKPiBC eSB0aGUgd2F5LCBkb2VzIHRoaXMgZml4IHlvdXIgcHJvYmxlbT8KPiAKPiBodHRwczovL3BhdGNo d29yay5rZXJuZWwub3JnL3BhdGNoLzE4NDc1Mi8KCkl0IHNob3VsZG4ndC4gQUZBSUssIGVTUEkg aXMgUElPLW9ubHkgY29udHJvbGxlciwgYW5kIHRoZSBvdmVycnVuCmZpeCBpcyBmb3IgdGhlIERN QSBtb2RlLgoKVGhhbmtzLAoKcC5zLiBCdHcsIGluIHBhdGNoIDMvNywgaXNfZG1hX21hcHBlZCBh cmd1bWVudCBvZiBmc2xfZXNwaV9idWZzKCkKaXMgdW5uZWVkZWQuCgotLSAKQW50b24gVm9yb250 c292CmVtYWlsOiBjYm91YXRtYWlscnVAZ21haWwuY29tCmlyYzovL2lyYy5mcmVlbm9kZS5uZXQv YmQyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4 cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcKaHR0cHM6 Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBjLWRldg==