All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org, joerg.roedel@amd.com,
	jbarnes@virtuousgeek.org
Subject: Re: [PATCH] pci: Reenable the AMD IOMMU if it's mysteriously vanished over suspend
Date: Thu, 30 Sep 2010 18:39:45 +0100	[thread overview]
Message-ID: <20100930173945.GA16596@srcf.ucam.org> (raw)
In-Reply-To: <1285861108-24122-1-git-send-email-mjg@redhat.com>

On Thu, Sep 30, 2010 at 11:38:28AM -0400, Matthew Garrett wrote:
> AMD's reference BIOS code had a bug that could result in the firmware
> failing to reenable the iommu on resume. It transpires that this causes
> certain less than desirable behaviour when it comes to PCI accesses, to
> whit them ending up somewhere near Bristol when the more desirable outcome
> was Edinburgh. Sadness ensues, perhaps along with filesystem corruption.
> Let's make sure that it gets turned back on.

Of course, this isn't actually sufficient - nothing in the iommu code 
appears to reprogram the BAR, for instance. Joerg, how is this meant to 
work?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2010-09-30 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30 15:38 [PATCH] pci: Reenable the AMD IOMMU if it's mysteriously vanished over suspend Matthew Garrett
2010-09-30 17:39 ` Matthew Garrett [this message]
2010-09-30 18:43   ` Joerg Roedel
2010-09-30 19:05     ` Matthew Garrett
2010-10-01 17:58 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100930173945.GA16596@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.