All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] lirc: Make struct file_operations pointer const
Date: Thu, 30 Sep 2010 16:19:14 -0400	[thread overview]
Message-ID: <20100930201914.GD8135@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1009302153210.2434@ayla.of.borg>

On Thu, Sep 30, 2010 at 09:55:07PM +0200, Geert Uytterhoeven wrote:
> struct file_operations was made const in the drivers, but not in struct
> lirc_driver:
> 
> drivers/staging/lirc/lirc_it87.c:365: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_parallel.c:571: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_serial.c:1073: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_sir.c:482: warning: initialization discards qualifiers from pointer target type
> drivers/staging/lirc/lirc_zilog.c:1284: warning: assignment discards qualifiers from pointer target type
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Whoops, yeah, obvious fix.

Acked-by: Jarod Wilson <jarod@redhat.com>


-- 
Jarod Wilson
jarod@redhat.com


      reply	other threads:[~2010-10-04 15:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30 19:55 [PATCH] lirc: Make struct file_operations pointer const Geert Uytterhoeven
2010-09-30 20:19 ` Jarod Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100930201914.GD8135@redhat.com \
    --to=jarod@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.