All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Rees <rees@umich.edu>
To: Steve Dickson <SteveD@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] pnfs:  compile error in blocklayout code
Date: Thu, 30 Sep 2010 16:22:56 -0400	[thread overview]
Message-ID: <20100930202256.GA6462@merit.edu> (raw)
In-Reply-To: <4CA4ED68.3090806@RedHat.com>

Steve Dickson wrote:

  I needed to make the following change to get the
  block layout code to compile in a Fedora build 
  environment.

  -#include <../pnfs.h>
  +#include "../pnfs.h"

Not a comment on your fix, which looks correct, but there is a bit of
disturbing asymmetry here.  The file layout source files are named
nfs4filelayout*.[ch] and live in fs/nfs, but object and block layout are
named {object,block}layout*.[ch] and live in fs/nfs/*layout.

  parent reply	other threads:[~2010-09-30 20:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30 20:04 [PATCH] pnfs: compile error in blocklayout code Steve Dickson
     [not found] ` <4CA4ED68.3090806-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-09-30 20:15   ` Benny Halevy
2010-09-30 20:22 ` Jim Rees [this message]
2010-09-30 20:30   ` Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100930202256.GA6462@merit.edu \
    --to=rees@umich.edu \
    --cc=SteveD@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.