From: Jan Kara <jack@suse.cz>
To: Jan Andres <jandres@gmx.net>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] isofs: Fix lseek() to position beyond 4 GB
Date: Fri, 1 Oct 2010 00:26:25 +0200 [thread overview]
Message-ID: <20100930222625.GH3573@quack.suse.cz> (raw)
In-Reply-To: <20100930221429.GF3573@quack.suse.cz>
On Fri 01-10-10 00:14:30, Jan Kara wrote:
> On Wed 04-08-10 22:52:46, Jan Andres wrote:
> > isofs supports files larger than 4 GB by using multi-extent files.
> > However an lseek() to a position beyond 4 GB in such a file will
> > fail with EINVAL, because s_maxbytes in the isofs superblock is
> > initialized to 2^32-1, and generic_file_llseek() checks against
> > that value.
> >
> > I therefore suggest increasing the value of s_maxbytes to have
> > full support for large files in isofs. With multi-extent files, file
> > size is only limited by the maximum size of the file system (8 TB),
> > so this seems a reasonable value for s_maxbytes.
> OK, I had a look into the relevant code and it seems that the isofs
> code should properly handle files upto 4TB and with a small fix (attached)
> upto 8TB as you claim. So I'll take your patch and merge it with Linus.
Oops, I now noticed that Al has already merged your patch. OK, so I'll
just merge my fix separately.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2010-09-30 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 21:18 [PATCH] isofs: Fix lseek() to position beyond 4 GB Jan Andres
2010-08-03 21:23 ` Joe Perches
2010-08-04 20:52 ` [PATCH v2] " Jan Andres
2010-09-30 22:14 ` Jan Kara
2010-09-30 22:26 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930222625.GH3573@quack.suse.cz \
--to=jack@suse.cz \
--cc=jandres@gmx.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.