From: "Rémi Denis-Courmont" <remi@remlab.net>
To: Kumar SANGHVI <kumar.sanghvi@stericsson.com>
Cc: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>,
"Sudeep DIVAKARAN" <sudeep.divakaran@stericsson.com>,
"Gulshan KARMANI" <gulshan.karmani@stericsson.com>,
"Linus WALLEIJ" <linus.walleij@stericsson.com>
Subject: Re: [PATCH v2 1/2] Phonet: Implement Pipe Controller to support Nokia Slim Modems
Date: Fri, 1 Oct 2010 12:20:52 +0300 [thread overview]
Message-ID: <201010011220.53162.remi@remlab.net> (raw)
In-Reply-To: <20101001085553.GA27109@bnru01.bnr.st.com>
Hello,
On Friday 01 October 2010, Kumar SANGHVI wrote:
> Hi,
>
> On Fri, Oct 01, 2010 at 10:42:44 +0200, Rémi Denis-Courmont wrote:
> > > I have not introduced any new ioctl()'s as part of Pipe controller
> > > implementation.
> >
> > Sure. What you did is basically worse than ioctl()'s. You've implemented
> > them as socket options. Socket options are meant to configure parameters
> > with setsockopt and read paramters with getsockopt. They are not meant
> > for 'doing' things - that's what ioctl()'s are for.
>
> Isn't the existing phonet stack 'doing' something as part of
> PNPIPE_ENCAP rather than simply configuring some socket option or flag ?
It sets (or gets) the delivery path for incoming data.
--
Rémi Denis-Courmont
http://www.remlab.net/
prev parent reply other threads:[~2010-10-01 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 5:07 [PATCH v2 1/2] Phonet: Implement Pipe Controller to support Nokia Slim Modems Kumar A Sanghvi
2010-09-28 4:50 ` David Miller
2010-09-28 5:31 ` Kumar SANGHVI
2010-09-28 22:25 ` Rémi Denis-Courmont
2010-09-29 6:32 ` Kumar SANGHVI
2010-09-29 18:21 ` Rémi Denis-Courmont
2010-09-30 7:19 ` Kumar SANGHVI
2010-10-01 8:42 ` Rémi Denis-Courmont
2010-10-01 8:55 ` Kumar SANGHVI
2010-10-01 9:20 ` Rémi Denis-Courmont [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010011220.53162.remi@remlab.net \
--to=remi@remlab.net \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=gulshan.karmani@stericsson.com \
--cc=kumar.sanghvi@stericsson.com \
--cc=linus.walleij@stericsson.com \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
--cc=sudeep.divakaran@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.