From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 01 Oct 2010 20:00:51 +0200 (CEST) Received: from opensource.wolfsonmicro.com ([80.75.67.52]:33598 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S1492015Ab0JASAo (ORCPT ); Fri, 1 Oct 2010 20:00:44 +0200 Received: from finisterre.wolfsonmicro.main (216-75-233-70.static.wiline.com [216.75.233.70]) by opensource2.wolfsonmicro.com (Postfix) with ESMTPSA id E59FA11023B; Fri, 1 Oct 2010 19:00:36 +0100 (BST) Received: from broonie by finisterre.wolfsonmicro.main with local (Exim 4.72) (envelope-from ) id 1P1jud-0005cK-N0; Fri, 01 Oct 2010 11:00:51 -0700 Date: Fri, 1 Oct 2010 11:00:51 -0700 From: Mark Brown To: Arun MURTHY Cc: Jassi Brar , Trilok Soni , "linux-mips@linux-mips.org" , Lars-Peter Clausen , "linux@arm.linux.org.uk" , "kernel@pengutronix.de" , Bill Gatliff , "linux-kernel@vger.kernel.org" , Linus WALLEIJ , Marek Vasut , "kgene.kim@samsung.com" , "rpurdie@rpsys.net" , "philipp.zabel@gmail.com" , Mattias WALLIN , STEricsson_nomadik_linux , "eric.y.miao@gmail.com" , Andrew Morton , "linux-omap@vger.kernel.org" , "robert.jarzmik@free.fr" , linux-arm-kernel , Samuel Ortiz Subject: Re: [PATCH 1/7] pwm: Add pwm core driver Message-ID: <20101001180051.GC21157@opensource.wolfsonmicro.com> References: <4CA1BC16.3020702@metafoo.de> <4CA25841.4090702@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You'll be sorry... User-Agent: Mutt/1.5.20 (2009-06-14) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 27913 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: broonie@opensource.wolfsonmicro.com Precedence: bulk X-list: linux-mips On Fri, Oct 01, 2010 at 10:46:15AM +0200, Arun MURTHY wrote: > > On Fri, Oct 1, 2010 at 4:25 PM, Arun MURTHY > > > I mean not the functions but the functionality. > > > PWM is a simple device and most of its clients are controlling > > intensity > > > of backlight, leds, vibrator etc. > > > I don't think these complex functionality are required. > > oh dear ! > Here I mean why should all those function be exposed to the entire kernel, > as most of the pwm devices do not use them. While many PWM uses are very simple that doesn't mean that we'll never need to support more advanced uses. Normally we try to design APIs so that they both scale down to the simplest use cases and also up to more complex ones. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/7] pwm: Add pwm core driver Date: Fri, 1 Oct 2010 11:00:51 -0700 Message-ID: <20101001180051.GC21157@opensource.wolfsonmicro.com> References: <4CA1BC16.3020702@metafoo.de> <4CA25841.4090702@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: Arun MURTHY Cc: Jassi Brar , Trilok Soni , "linux-mips@linux-mips.org" , Lars-Peter Clausen , "linux@arm.linux.org.uk" , "kernel@pengutronix.de" , Bill Gatliff , "linux-kernel@vger.kernel.org" , Linus WALLEIJ , Marek Vasut , "kgene.kim@samsung.com" , "rpurdie@rpsys.net" , "philipp.zabel@gmail.com" , Mattias WALLIN , STEricsson_nomadik_linux , "eric.y.miao@gmail.com" , Andrew List-Id: linux-omap@vger.kernel.org On Fri, Oct 01, 2010 at 10:46:15AM +0200, Arun MURTHY wrote: > > On Fri, Oct 1, 2010 at 4:25 PM, Arun MURTHY > > > I mean not the functions but the functionality. > > > PWM is a simple device and most of its clients are controlling > > intensity > > > of backlight, leds, vibrator etc. > > > I don't think these complex functionality are required. > > oh dear ! > Here I mean why should all those function be exposed to the entire kernel, > as most of the pwm devices do not use them. While many PWM uses are very simple that doesn't mean that we'll never need to support more advanced uses. Normally we try to design APIs so that they both scale down to the simplest use cases and also up to more complex ones. From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Fri, 1 Oct 2010 11:00:51 -0700 Subject: [PATCH 1/7] pwm: Add pwm core driver In-Reply-To: References: <4CA1BC16.3020702@metafoo.de> <4CA25841.4090702@metafoo.de> Message-ID: <20101001180051.GC21157@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 01, 2010 at 10:46:15AM +0200, Arun MURTHY wrote: > > On Fri, Oct 1, 2010 at 4:25 PM, Arun MURTHY > > > I mean not the functions but the functionality. > > > PWM is a simple device and most of its clients are controlling > > intensity > > > of backlight, leds, vibrator etc. > > > I don't think these complex functionality are required. > > oh dear ! > Here I mean why should all those function be exposed to the entire kernel, > as most of the pwm devices do not use them. While many PWM uses are very simple that doesn't mean that we'll never need to support more advanced uses. Normally we try to design APIs so that they both scale down to the simplest use cases and also up to more complex ones.