From: "J. Bruce Fields" <bfields@fieldses.org>
To: Benny Halevy <bhalevy@panasas.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] nfsd4: adjust buflen for encoded attrs bitmap based on actual bitmap length
Date: Fri, 1 Oct 2010 18:05:08 -0400 [thread overview]
Message-ID: <20101001220508.GF1472@fieldses.org> (raw)
In-Reply-To: <4CA5FBAB.2040309@panasas.com>
On Fri, Oct 01, 2010 at 05:18:03PM +0200, Benny Halevy wrote:
> On 2010-10-01 16:50, J. Bruce Fields wrote:
> > On Thu, Sep 30, 2010 at 08:47:46PM +0200, Benny Halevy wrote:
> >> The existing code adjusted it based on the worst case scenario for the returned
> >> bitmap and the best case scenario for the supported attrs attribute.
> >
> > Looks fine, thanks. Mind if I just ditch the unlikely()s? I know,
> > they've been there for a while, but I'm just skeptical of their value on
> > anything but the most unbelievably hot optimized-to-death code paths.
>
> Well, they don't bother me so I don't the value of ditching them either :)
For me it's an infinitessimal optimization versus a very minor
improvement in readability.
Admittedly my scales of judgement may not be fine enough to correctly
balance such small quantities....
Anyway, applied without annotations; thanks.
--b.
>
> They're supposed to help branch prediction thus optimizing the common
> code paths on the expense of the unlikely path but I too didn't measure
> their affect.
>
> Bottom line is that I don't have and strong reservations either for or
> against them in this case :)
prev parent reply other threads:[~2010-10-01 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 18:47 [PATCH 1/2] nfsd4: adjust buflen for encoded attrs bitmap based on actual bitmap length Benny Halevy
2010-10-01 14:50 ` J. Bruce Fields
2010-10-01 15:18 ` Benny Halevy
2010-10-01 22:05 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001220508.GF1472@fieldses.org \
--to=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.