From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Masayuki Ohtak <masa-korg@dsn.okisemi.com>
Cc: meego-dev@meego.com, "Andrew Morton" <akpm@linux-foundation.org>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Randy Dunlap" <randy.dunlap@oracle.com>,
"Alek Du" <alek.du@intel.com>,
"Richard Röjfors" <richard.rojfors@mocean-labs.com>,
"Mike Frysinger" <vapier@gentoo.org>,
linux-kernel@vger.kernel.org, qi.wang@intel.com,
andrew.chih.howe.khor@intel.com, kok.howg.ewe@intel.com,
joel.clark@intel.com, yong.y.wang@intel.com,
"Tomoya MORINAGA" <morinaga526@dsn.okisemi.com>,
margie.foster@intel.com
Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_GPIO driver to 2.6.35
Date: Fri, 1 Oct 2010 16:01:33 -0700 [thread overview]
Message-ID: <20101001230133.GG21157@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4CA29466.602@dsn.okisemi.com>
On Wed, Sep 29, 2010 at 10:20:38AM +0900, Masayuki Ohtak wrote:
> +static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr,
> + int val)
> +{
> + struct pch_gpio *chip = container_of(gpio, struct pch_gpio, gpio);
> + u32 pm;
> +
> + mutex_lock(&chip->lock);
> + pm = ioread32(&chip->reg->pm) & PCH_GPIO_ALL_PINS;
> + pm |= (1 << nr);
> + iowrite32(pm, &chip->reg->pm);
> + mutex_unlock(&chip->lock);
> +
> + return 0;
> +}
This doesn't do anything with val - it should be doing the equivalent of
a gpio_set() to set the initial value of the GPIO when switching it to
output mode.
Otherwise this looks good.
prev parent reply other threads:[~2010-10-01 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 1:20 [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_GPIO driver to 2.6.35 Masayuki Ohtak
2010-10-01 23:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001230133.GG21157@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=alek.du@intel.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=meego-dev@meego.com \
--cc=morinaga526@dsn.okisemi.com \
--cc=qi.wang@intel.com \
--cc=randy.dunlap@oracle.com \
--cc=richard.rojfors@mocean-labs.com \
--cc=sameo@linux.intel.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.