From: "J. Bruce Fields" <bfields@fieldses.org>
To: Neil Brown <neilb@suse.de>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/7] sunrpc: fix race in new cache_wait code.
Date: Fri, 1 Oct 2010 19:09:41 -0400 [thread overview]
Message-ID: <20101001230941.GA12203@fieldses.org> (raw)
In-Reply-To: <20100923144647.GD1054@fieldses.org>
On Thu, Sep 23, 2010 at 10:46:47AM -0400, J. Bruce Fields wrote:
> On Wed, Sep 22, 2010 at 11:25:40PM -0400, J. Bruce Fields wrote:
> > On Thu, Sep 23, 2010 at 01:00:02PM +1000, Neil Brown wrote:
> > > How about this.
> > > It gets rid of the return values (which were confusing anyway) and adds
> > > explicit checks on CAHCE_PENDING where needed.
> > > ??
> >
> > Thanks, I'll take a look in the morning when my head's (hopefully)
> > clearer.
>
> Looks reasonable to me on a quick skim.
>
> > > Also, I noticed there is a race with the call to cache_limit_defers. The
> > > 'dreq' could be freed before that is called.
> > >
> > > It looks like I need to resubmit a lot of this - do you want to just discard
> > > it all from your -next and I'll make something new?
> >
> > I'm trying very hard not to rewind -next; so I'd prefer incremental
> > patches for anything already there, replacements for the rest.
>
> But I'll wait for a new series. Thanks!
Well, just to have the bug fixed, I've applied your simple original fix
(1/7), but would still happily take incremental cleanup.
Out of this series that just leaves
[PATCH 4/7] sunrpc/cache: centralise handling of size limit on
deferred list.
[PATCH 5/7] sunrpc/cache: allow thread manager more control of
whether threads can wait for upcalls
(And with no particular objection to either--they just seemed more RFC's
than "please apply"'s.)
--b.
next prev parent reply other threads:[~2010-10-01 23:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 2:55 [PATCH 0/7] Assorted nfsd patches for 2.6.37 NeilBrown
2010-09-22 2:55 ` [PATCH 1/7] sunrpc: fix race in new cache_wait code NeilBrown
2010-09-22 17:50 ` J. Bruce Fields
2010-09-23 3:00 ` Neil Brown
2010-09-23 3:25 ` J. Bruce Fields
2010-09-23 14:46 ` J. Bruce Fields
2010-10-01 23:09 ` J. Bruce Fields [this message]
2010-10-02 0:12 ` Neil Brown
2010-09-22 2:55 ` [PATCH 2/7] sunrpc/cache: fix recent breakage of cache_clean_deferred NeilBrown
[not found] ` <20100922025506.31745.74964.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-09-22 18:27 ` J. Bruce Fields
2010-09-22 2:55 ` [PATCH 3/7] sunrpc/cache: change deferred-request hash table to use hlist NeilBrown
2010-09-22 2:59 ` J. Bruce Fields
2010-09-22 4:51 ` Neil Brown
2010-09-22 2:55 ` [PATCH 5/7] sunrpc/cache: allow thread manager more control of whether threads can wait for upcalls NeilBrown
2010-09-22 18:36 ` J. Bruce Fields
2010-09-23 3:23 ` Neil Brown
2010-09-22 2:55 ` [PATCH 6/7] nfsd: formally deprecate legacy nfsd syscall interface NeilBrown
[not found] ` <20100922025507.31745.57024.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-09-22 3:10 ` J. Bruce Fields
2010-09-22 2:55 ` [PATCH 4/7] sunrpc/cache: centralise handling of size limit on deferred list NeilBrown
[not found] ` <20100922025507.31745.61919.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-09-22 18:31 ` J. Bruce Fields
2010-09-23 3:02 ` Neil Brown
2010-09-22 2:55 ` [PATCH 7/7] nfsd: allow deprecated interface to be compiled out NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001230941.GA12203@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.