From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50202 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P20Kv-0007s4-9j
	for qemu-devel@nongnu.org; Sat, 02 Oct 2010 07:33:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1P20AT-0003bJ-TT
	for qemu-devel@nongnu.org; Sat, 02 Oct 2010 07:22:18 -0400
Received: from mail-ey0-f173.google.com ([209.85.215.173]:48403)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1P20AT-0003bF-MT
	for qemu-devel@nongnu.org; Sat, 02 Oct 2010 07:22:17 -0400
Received: by eyf18 with SMTP id 18so1812428eyf.4
	for <qemu-devel@nongnu.org>; Sat, 02 Oct 2010 04:22:16 -0700 (PDT)
Date: Sat, 2 Oct 2010 13:22:12 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] powerpc: Add a virtex5 ml507
	refdesign board (v2)
Message-ID: <20101002112212.GC10823@laped.lan>
References: <1285767655-13485-1-git-send-email-edgar.iglesias@gmail.com>
	<4CA48D8A.70000@suse.de> <20100930171226.GB10823@laped.lan>
	<4CA7115A.8060201@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CA7115A.8060201@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

On Sat, Oct 02, 2010 at 01:02:50PM +0200, Stefan Weil wrote:
> Am 30.09.2010 19:12, schrieb Edgar E. Iglesias:
> > On Thu, Sep 30, 2010 at 03:15:54PM +0200, Alexander Graf wrote:
> >> Edgar E. Iglesias wrote:
> >>> v2:
> >>> * Address review comments from A. Graf.
> >>>
> >>> Edgar E. Iglesias (2):
> >>> powerpc: Add a ppc-440x5 Xilinx model
> >>> powerpc: Add a virtex5 ml507 refdesign board
> >>>
> >>> Makefile.target | 8 +
> >>> default-configs/ppc-softmmu.mak | 2 +
> >>> default-configs/ppc64-softmmu.mak | 2 +
> >>> default-configs/ppcemb-softmmu.mak | 2 +
> >>> hw/virtex_ml507.c | 278 ++++++++++++++++++++++++++++++++++++
> >>> target-ppc/cpu.h | 4 +
> >>> target-ppc/translate_init.c | 6 +-
> >>> 7 files changed, 300 insertions(+), 2 deletions(-)
> >>> create mode 100644 hw/virtex_ml507.c
> >>>
> >>>
> >>>
> >> No complaints from me. Feel free to apply them.
> >>
> >> Signed-off-by: Alexander Graf <agraf@suse.de>
> >
> > Applied, thanks.
> >
> > Cheers
> >
> >
> 
> What about coding conventions?
> New source files should comply with CODING_STYLE (block structure).
> 
> virtex_ml507.c:
> 
> + if (!fdt)
> + return 0;

Fixed, thanks.