From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off Date: Sun, 3 Oct 2010 08:10:48 -0700 Message-ID: <20101003081048.5013dd26@jbarnes-x201> References: <1286091186-3654-1-git-send-email-keithp@keithp.com> <1286091186-3654-2-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cpoproxy2-pub.bluehost.com (cpoproxy2-pub.bluehost.com [67.222.39.38]) by gabe.freedesktop.org (Postfix) with SMTP id 31EC29E70A for ; Sun, 3 Oct 2010 08:10:55 -0700 (PDT) In-Reply-To: <1286091186-3654-2-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sun, 3 Oct 2010 00:33:06 -0700 Keith Packard wrote: > Instead of waiting for the display line value to settle, we can simply > wait for the pipe configuration register 'state' bit to turn off. > > Contrarywise, disabling the plane will not cause the display line > value to stop changing, so instead we wait for the vblank interrupt > bit to get set. And, we only do this when we're not about to wait for > the pipe to turn off. > > Signed-off-by: Keith Packard > --- Do these fixes help with the DP issues you've been seeing, Keith? Seems like the first one shouldn't change behavior since we ought to time out on waiting on vblank in that case, and the timeout is the same as the msleep we used to use. The second one looks like a good change, but really the pipe off change is separate from the plane disable bug fix. -- Jesse Barnes, Intel Open Source Technology Center