From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/2 v2] nand: allow delayed initialization
Date: Sun, 03 Oct 2010 20:27:13 +0200 [thread overview]
Message-ID: <20101003182713.6562C1539A0@gemini.denx.de> (raw)
In-Reply-To: <1286048840-1901-1-git-send-email-vapier@gentoo.org>
Dear Mike Frysinger,
In message <1286048840-1901-1-git-send-email-vapier@gentoo.org> you wrote:
> Many people like the current nand_init() behavior where it is always
> initialized during boot and the flash size shown, but there are cases
> where we are willing to forgo this niceness for speed/functionality.
> So rather than change the default, introduce a delayed config option
> people may enable. This way the nand is only poked when someone tries
> to actually use it.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
...
> extern void nand_init(void);
> +#ifdef CONFIG_SYS_NAND_DELAYED_INIT
> +# define nand_delayed_init() nand_init()
> +#else
> +# define nand_delayed_init() do { } while (0)
> +#endif
Would it not be esier to rename your nand_delayed_init() into
nand_init(), and add a "#ifndef CONFIG_SYS_NAND_DELAYED_INIT" around
the current call to nand_init()?
Question: is there a risk of problems with boards that have the
environment in NAND?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Don't think; let the machine do it for you!" - E. C. Berkeley
next prev parent reply other threads:[~2010-10-03 18:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 23:45 [U-Boot] [RFC PATCH 1/2] nand: allow delayed initialization Mike Frysinger
2010-09-21 23:45 ` [U-Boot] [PATCH 2/2] Blackfin: nand: support " Mike Frysinger
2010-10-02 19:47 ` [U-Boot] [RFC PATCH 1/2 v2] nand: allow " Mike Frysinger
2010-10-03 18:27 ` Wolfgang Denk [this message]
2010-10-03 20:32 ` Mike Frysinger
2010-10-03 21:40 ` Wolfgang Denk
2010-10-03 22:19 ` Mike Frysinger
2010-10-06 20:40 ` Wolfgang Denk
2010-10-07 17:00 ` Mike Frysinger
2010-10-07 19:35 ` Wolfgang Denk
2010-10-07 21:26 ` Mike Frysinger
2010-10-08 2:00 ` Mike Frysinger
2010-10-10 8:37 ` Mike Frysinger
2010-10-10 9:20 ` Wolfgang Denk
2010-10-04 17:36 ` Scott Wood
2010-10-05 8:08 ` Mike Frysinger
2010-10-05 16:31 ` Scott Wood
2010-10-05 18:27 ` Wolfgang Denk
2010-10-05 19:18 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003182713.6562C1539A0@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.