From: Simon Horman <horms@verge.net.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: lvs-devel@vger.kernel.org
Subject: Re: [patch v3 00/12] IPVS: SIP Persistence Engine
Date: Mon, 4 Oct 2010 17:07:04 +0900 [thread overview]
Message-ID: <20101004080704.GA10230@verge.net.au> (raw)
In-Reply-To: <alpine.LFD.2.00.1010032356550.2597@ja.ssi.bg>
On Mon, Oct 04, 2010 at 12:08:32AM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Sun, 3 Oct 2010, Simon Horman wrote:
>
> >>>REVISIONS
> >>>
> >>>This is v3 of the patch series with addresses serveral problems
> >>>raised by Julian Anastasov on the lvs-devel mailing list.
> >>
> >> No other obvious problems in v3 1-12. So,
> >>Acked-by: Julian Anastasov <ja@ssi.bg>
> >
> >Thanks.
> >
> >
> >> May be next days I'll test my changes on top of PE v3
> >
> >I think that could save a bit of porting work later
> >and perhaps you might notice some more bugs too :-)
>
> Appending fixes from my tests:
>
> - initialize compat structures to avoid crash in
> ip_vs_add_service for pe_name
>
> - fix ip_vs_conn_out_get_proto to properly check the
> ip_vs_conn_fill_param_proto result
>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
> ---
>
> diff -urp net-next-2.6-e548833-test_pe3/linux/net/netfilter/ipvs/ip_vs_conn.c linux/net/netfilter/ipvs/ip_vs_conn.c
> --- net-next-2.6-e548833-test_pe3/linux/net/netfilter/ipvs/ip_vs_conn.c 2010-10-03 23:08:47.928356111 +0300
> +++ linux/net/netfilter/ipvs/ip_vs_conn.c 2010-10-03 23:32:47.309353117 +0300
> @@ -439,7 +439,7 @@ ip_vs_conn_out_get_proto(int af, const s
> {
> struct ip_vs_conn_param p;
>
> - if (!ip_vs_conn_fill_param_proto(af, skb, iph, proto_off, inverse, &p))
> + if (ip_vs_conn_fill_param_proto(af, skb, iph, proto_off, inverse, &p))
> return NULL;
>
> return ip_vs_conn_out_get(&p);
Thanks, I'll roll that into "IPVS: Add struct ip_vs_conn_param" and repost.
> diff -urp net-next-2.6-e548833-test_pe3/linux/net/netfilter/ipvs/ip_vs_ctl.c linux/net/netfilter/ipvs/ip_vs_ctl.c
> --- net-next-2.6-e548833-test_pe3/linux/net/netfilter/ipvs/ip_vs_ctl.c 2010-10-03 22:33:53.881353731 +0300
> +++ linux/net/netfilter/ipvs/ip_vs_ctl.c 2010-10-03 22:49:48.279355927 +0300
> @@ -2057,6 +2057,7 @@ static const unsigned char set_arglen[SE
> static void ip_vs_copy_usvc_compat(struct ip_vs_service_user_kern *usvc,
> struct ip_vs_service_user *usvc_compat)
> {
> + memset(usvc, 0, sizeof(*usvc));
> usvc->af = AF_INET;
> usvc->protocol = usvc_compat->protocol;
> usvc->addr.ip = usvc_compat->addr;
> @@ -2074,6 +2075,7 @@ static void ip_vs_copy_usvc_compat(struc
> static void ip_vs_copy_udest_compat(struct ip_vs_dest_user_kern *udest,
> struct ip_vs_dest_user *udest_compat)
> {
> + memset(udest, 0, sizeof(*udest));
> udest->addr.ip = udest_compat->addr;
> udest->port = udest_compat->port;
> udest->conn_flags = udest_compat->conn_flags;
>
Thanks, I'll add this as a new patch the persistence engine series,
though unless I'm mistaken its resolves existing concerns not new ones.
next prev parent reply other threads:[~2010-10-04 8:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 2:30 [patch v3 00/12] IPVS: SIP Persistence Engine Simon Horman
2010-10-02 2:30 ` [patch v3 01/12] netfilter: nf_conntrack_sip: Allow ct_sip_get_header() to be called with a null ct argument Simon Horman
2010-10-02 2:30 ` [patch v3 02/12] netfilter: nf_conntrack_sip: Add callid parser Simon Horman
2010-10-02 2:30 ` [patch v3 03/12] IPVS: compact ip_vs_sched_persist() Simon Horman
2010-10-02 2:31 ` [patch v3 04/12] IPVS: Add struct ip_vs_conn_param Simon Horman
2010-10-02 2:31 ` [patch v3 05/12] IPVS: Allow null argument to ip_vs_scheduler_put() Simon Horman
2010-10-02 2:31 ` [patch v3 06/12] IPVS: ip_vs_{un,}bind_scheduler NULL arguments Simon Horman
2010-10-02 2:31 ` [patch v3 07/12] IPVS: Add struct ip_vs_pe Simon Horman
2010-10-02 2:31 ` [patch v3 08/12] IPVS: Add persistence engine data to /proc/net/ip_vs_conn Simon Horman
2010-10-02 2:31 ` [patch v3 09/12] IPVS: management of persistence engine modules Simon Horman
2010-10-02 2:31 ` [patch v3 10/12] IPVS: Allow configuration of persistence engines Simon Horman
2010-10-02 2:31 ` [patch v3 11/12] IPVS: Fallback if persistence engine fails Simon Horman
2010-10-02 2:31 ` [patch v3 12/12] IPVS: sip persistence engine Simon Horman
2010-10-02 9:00 ` [patch v3 00/12] IPVS: SIP Persistence Engine Julian Anastasov
2010-10-03 5:07 ` Simon Horman
2010-10-03 21:08 ` Julian Anastasov
2010-10-04 8:07 ` Simon Horman [this message]
2010-10-04 8:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004080704.GA10230@verge.net.au \
--to=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.