From: Amit Kucheria <amit.kucheria@linaro.org>
To: "Sripathy, Vishwanath" <vishwanath.bs@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linaro-dev@lists.linaro.org" <linaro-dev@lists.linaro.org>
Subject: Re: [PATCH 2/2] OMAP3 PM: sleep code clean up
Date: Mon, 4 Oct 2010 11:56:40 +0300 [thread overview]
Message-ID: <20101004085640.GA2529@matterhorn.lan> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC356087034B6EC6A5@dbde02.ent.ti.com>
On 10 Oct 04, Sripathy, Vishwanath wrote:
> Kevin,
[snip]
> >
> > But this also makes me wonder, if we're going to clean this up, the bulk
> > of it could be re-written in C, with some inline asm helpers as needed.
> Probably yes. But as this code is specific to OMAP3, do you think it's
> worth spending time on rewriting the entire code in C? It might be a
> significant effort and it will not be reusable for other ARM SOCs.
The C code will be more maintainable and offer more opportunities to
refactor across OMAP flavours - perhaps OMAP4 as well.
I'm also interested in code reuse across other SoCs. We've got to be able to
shut down the ARM core using common code instead of each SoC copying buggy
code from each other. Could you list reasons why you don't think the code is
re-usable?
Regards,
Amit
next prev parent reply other threads:[~2010-10-04 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 10:56 [PATCH 0/2] OMAP3 PM: sleep code clean up Vishwanath BS
2010-09-24 10:56 ` [PATCH 1/2] OMAP3 PM: move omap3 sleep to ddr Vishwanath BS
2010-09-24 19:01 ` Tony Lindgren
2010-09-24 19:09 ` Tony Lindgren
[not found] ` <20100924190930.GH4211-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-09-25 5:52 ` Shilimkar, Santosh
2010-09-24 19:57 ` Kevin Hilman
2010-10-04 7:26 ` Sripathy, Vishwanath
2010-09-24 10:56 ` [PATCH 2/2] OMAP3 PM: sleep code clean up Vishwanath BS
[not found] ` <1285325785-6163-3-git-send-email-vishwanath.bs-l0cyMroinI0@public.gmane.org>
2010-09-24 20:05 ` Kevin Hilman
2010-10-04 8:44 ` Sripathy, Vishwanath
2010-10-04 8:56 ` Amit Kucheria [this message]
2010-10-04 9:36 ` Shilimkar, Santosh
-- strict thread matches above, loose matches on Subject: below --
2010-09-24 10:47 [PATCH 0/2] " Vishwanath BS
2010-09-24 10:47 ` [PATCH 2/2] " Vishwanath BS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004085640.GA2529@matterhorn.lan \
--to=amit.kucheria@linaro.org \
--cc=khilman@deeprootsystems.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.