From: Alan Cox <alan@linux.intel.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: David Miller <davem@davemloft.net>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org
Subject: Re: piix vs ata_piix device ID tables
Date: Mon, 4 Oct 2010 10:21:45 +0100 [thread overview]
Message-ID: <20101004102145.2f34cc62@linux.intel.com> (raw)
In-Reply-To: <1286164252.3916.312.camel@localhost>
On Mon, 04 Oct 2010 04:50:52 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:
> When I converted the Debian kernel configurations over from IDE to
> libata-based drivers, I compared the device ID tables for all the PCI
> drivers. I found that ata_piix handles most of the same devices as
> piix while pata_oldpiix and pata_mpiix each handle one more.
> However, 2 device IDs in piix are not in the device ID tables of any
> libata-based driver:
>
> PCI_DEVICE_ID_INTEL_82371FB_0 == 0x122e (PIIX function 0)
>
> piix seems to treat this the same as PCI_DEVICE_ID_INTEL_82371FB_1 ==
> 0x1230, which is handled by pata_oldpiix. (This is weird; function 0
> is supposed to be the ISA bridge!)
Given that pre PIIX3 devices (MPIIX and PIIX original) never worked in
the old IDE code (well sometimes semi-worked by accident because the
BIOS values were right and they didn't break anything) I wouldn't draw
any conclusions.
> PCI_DEVICE_ID_INTEL_82801DB_1 == 0x24c1 (ICH4 device 31 function 1)
>
> piix seems to treat this the same as most other ICH PATA interfaces,
> which are handled by ata_piix.
>
> Does anyone know why these aren't handled by the libata-based drivers?
I don't know about 0x24C1 however it isn't listed in the Intel ICH
programming manual so given we've also had no reports about it I
suspect it's an error in the PIIX driver ?
Alan
next prev parent reply other threads:[~2010-10-04 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 3:50 piix vs ata_piix device ID tables Ben Hutchings
2010-10-04 9:21 ` Alan Cox [this message]
2010-10-04 20:09 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004102145.2f34cc62@linux.intel.com \
--to=alan@linux.intel.com \
--cc=ben@decadent.org.uk \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.