All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: linux-mmc@vger.kernel.org
Subject: [PATCH 1/3] sdhci: Allow the probe handler to override slots
Date: Mon, 04 Oct 2010 15:06:42 +0100	[thread overview]
Message-ID: <20101004140633.14608.59308.stgit@localhost.localdomain> (raw)
In-Reply-To: <20101004140454.14608.70665.stgit@localhost.localdomain>

Currently we write it to the chip data, but if the probe handler overrides
it we ignore the new value and keep using our cached one. Fix this so that
a probe handler can adjust the slot count

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 drivers/mmc/host/sdhci-pci.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index e8aa99d..4f5d6d0 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -818,6 +818,8 @@ static int __devinit sdhci_pci_probe(struct pci_dev *pdev,
 			goto free;
 	}
 
+	slots = chip->num_slots;	/* Quirk may have changed this */
+
 	for (i = 0;i < slots;i++) {
 		slot = sdhci_pci_probe_slot(pdev, chip, first_bar + i);
 		if (IS_ERR(slot)) {


  reply	other threads:[~2010-10-04 15:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 14:06 [PATCH 0/3] Initial Intel MID support for SDHCI Alan Cox
2010-10-04 14:06 ` Alan Cox [this message]
2010-10-04 14:07 ` [PATCH 2/3] sdhci: Intel Medfield support Alan Cox
2010-10-04 14:07 ` [PATCH 3/3] sdhci: Add Moorestown devices Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2010-10-04 14:23 [PATCH 0/3] Enabling patches for Intel MID SDHCI Alan Cox
2010-10-04 14:24 ` [PATCH 1/3] sdhci: Allow the probe handler to override slots Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101004140633.14608.59308.stgit@localhost.localdomain \
    --to=alan@linux.intel.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.