From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH] x86: Reenable the AMD IOMMU if it's mysteriously vanished over suspend
Date: Mon, 4 Oct 2010 16:13:45 +0200 [thread overview]
Message-ID: <20101004141345.GU9817@amd.com> (raw)
In-Reply-To: <20101004135552.GA5063@srcf.ucam.org>
On Mon, Oct 04, 2010 at 09:55:52AM -0400, Matthew Garrett wrote:
> On Mon, Oct 04, 2010 at 03:43:39PM +0200, Roedel, Joerg wrote:
> >
> > Why have you moved this out of the enable_iommus() loop?
>
> enable_iommus() is called on init, whereas this should only be performed
> on resume.
Ok, it shouldn't be problematic to do this always, but only on resume is
safer. Can you rename iommu_apply_quirks to iommu_apply_resume_quirks
then?
> I'll send out an updated patch later today.
Great. Looking forward to it.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-10-04 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 14:01 [PATCH] x86: Reenable the AMD IOMMU if it's mysteriously vanished over suspend Matthew Garrett
2010-10-04 13:43 ` Roedel, Joerg
2010-10-04 13:55 ` Matthew Garrett
2010-10-04 14:13 ` Roedel, Joerg [this message]
2010-10-04 18:59 ` [PATCH v2] " Matthew Garrett
2010-10-06 10:07 ` Roedel, Joerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004141345.GU9817@amd.com \
--to=joerg.roedel@amd.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=stable@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.