From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/6] mac80211: keep lock when calling __ieee80211_scan_completed()
Date: Mon, 4 Oct 2010 16:52:13 +0200 [thread overview]
Message-ID: <20101004145212.GA16478@redhat.com> (raw)
In-Reply-To: <1286197746.3620.30.camel@jlt3.sipsolutions.net>
On Mon, Oct 04, 2010 at 03:09:06PM +0200, Johannes Berg wrote:
> On Fri, 2010-10-01 at 14:05 +0200, Stanislaw Gruszka wrote:
>
> > out_complete:
> > + finish = false;
> > + if (rc) {
> > + hw_scan = test_bit(SCAN_HW_SCANNING, &local->scanning);
> > + finish = __ieee80211_scan_completed(&local->hw, aborted, hw_scan);
> > + }
> > +
> > mutex_unlock(&local->mtx);
> > - if (rc)
> > - __ieee80211_scan_completed(&local->hw, true);
> > +
> > + if (finish)
> > + __ieee80211_scan_completed_finish(&local->hw, hw_scan);
> > }
>
> And this makes the logic here even more confusing :-)
I'll try to rewrite that more clean.
Stanislaw
next prev parent reply other threads:[~2010-10-04 14:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 12:05 [PATCH 1/6] mac80211: perform scan cancel in hw reset work Stanislaw Gruszka
2010-10-01 12:05 ` [PATCH 2/6] mac80211: merge ieee80211_scan_work() common code Stanislaw Gruszka
2010-10-04 13:02 ` Johannes Berg
2010-10-04 13:07 ` Johannes Berg
2010-10-01 12:05 ` [PATCH 3/6] mac80211: keep lock when calling __ieee80211_scan_completed() Stanislaw Gruszka
2010-10-04 13:09 ` Johannes Berg
2010-10-04 14:52 ` Stanislaw Gruszka [this message]
2010-10-01 12:05 ` [PATCH 4/6] mac80211: assure we also cancel deferred scan request Stanislaw Gruszka
2010-10-04 13:11 ` Johannes Berg
2010-10-04 15:17 ` Stanislaw Gruszka
2010-10-01 12:05 ` [PATCH 5/6] mac80211: do not requeue scan work when not needed Stanislaw Gruszka
2010-10-01 12:05 ` [PATCH 6/6] Revert "iwlwifi: do not perferm force reset while doing scan" Stanislaw Gruszka
2010-10-01 16:11 ` [PATCH 1/6] mac80211: perform scan cancel in hw reset work Johannes Berg
2010-10-01 17:20 ` Luis R. Rodriguez
2010-10-05 9:25 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004145212.GA16478@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.