From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Drake <dsd@laptop.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] serial8250: ratelimit "too much work" error
Date: Mon, 4 Oct 2010 15:02:38 -0700 [thread overview]
Message-ID: <20101004150238.fbc1b6cf.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101004145101.b28fdc0a.akpm@linux-foundation.org>
On Mon, 4 Oct 2010 14:51:01 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> someone stuck a
> DEFINE_RATELIMIT_STATE() in include/linux/kernel.h and it ain't defined
> anywhere. Let me fix that up...
Well that's a PITA. Can't include ratelimit.h into kernel.h because a)
it'll slow everyone's compiels down and b) ratelimit.h needs spinlock.h
which surely needs kernel.h. Fixable by adding a new
printk_ratelimit.h and including that from 135 source files, blah.
I'll give up and pronounce that users of printk_ratelimited() need to
include ratelimit.h as well.
next prev parent reply other threads:[~2010-10-04 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 11:04 [PATCH] serial8250: ratelimit "too much work" error Daniel Drake
2010-10-02 11:04 ` Daniel Drake
2010-10-02 14:22 ` Alan Cox
2010-10-04 21:51 ` Andrew Morton
2010-10-04 22:02 ` Andrew Morton [this message]
2010-10-04 22:10 ` Joe Perches
2010-10-04 22:21 ` Andrew Morton
2010-10-04 22:59 ` Joe Perches
2010-10-04 23:11 ` Andrew Morton
2010-10-04 23:34 ` Joe Perches
2010-10-04 23:49 ` Andrew Morton
2010-10-05 0:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004150238.fbc1b6cf.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dsd@laptop.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.