All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
	fweisbec@gmail.com, perfmon2-devel@lists.sf.net,
	eranian@gmail.com, robert.richter@amd.com
Subject: Re: [PATCH] perf: fix extern struct definitions
Date: Mon, 4 Oct 2010 15:02:00 -0300	[thread overview]
Message-ID: <20101004180200.GC4420@ghostprotocols.net> (raw)
In-Reply-To: <4c97e41a.078fd80a.7a8b.3cc9@mx.google.com>

Em Tue, Sep 21, 2010 at 12:45:01AM +0200, Stephane Eranian escreveu:
> Both python_scripting_ops and perl_scripting_ops have two global definitions.
> One in trace-event-scripting.c and one in their respective scripting-engine
> modules.
> 
> The issue is that depending on the linker order one definition or the other
> is chosen. One is uninitialized (bss), while the other is initialized. If
> the uninitialized version is chosen, then perf does not function properly.
> 
> This patch fixes this by adding the extern prefix to the definitions in
> trace-event-scripting.c. 
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>

Thanks, applying to perf/urgent,

- Arnaldo

  reply	other threads:[~2010-10-04 18:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20 22:45 [PATCH] perf: fix extern struct definitions Stephane Eranian
2010-10-04 18:02 ` Arnaldo Carvalho de Melo [this message]
2010-10-05 12:13 ` [tip:perf/core] perf trace scripting: Fix " tip-bot for Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101004180200.GC4420@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=davem@davemloft.net \
    --cc=eranian@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=perfmon2-devel@lists.sf.net \
    --cc=peterz@infradead.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.