All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Daniel Drake <dsd@laptop.org>,
	Andres Salomon <dilinger@queued.net>, Chris Ball <cjb@laptop.org>,
	linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: Dynamic nop selection breaks boot on Geode LX
Date: Mon, 4 Oct 2010 16:39:22 -0400	[thread overview]
Message-ID: <20101004203921.GG2900@redhat.com> (raw)
In-Reply-To: <1286224272.6750.70.camel@gandalf.stny.rr.com>

On Mon, Oct 04, 2010 at 04:31:12PM -0400, Steven Rostedt wrote:
> On Mon, 2010-10-04 at 11:46 -0400, Jason Baron wrote:
> 
> >  	restart_nmi();
> > +
> > +	local_irq_save(flags);
> > +	arch_init_ideal_nop5();
> > +	local_irq_restore(flags);
> >  }
> >  
> >  /**
> 
> BTW, why the irq disabling around the call?
> 
> -- Steve
> 
> 

Only b/c the selection of the nop was originally done by
'ftrace_dyn_arch_init()' which had irq's disabled around it. So maybe
that can be dropped now?

thanks,

-Jason

  reply	other threads:[~2010-10-04 20:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-02 19:16 Dynamic nop selection breaks boot on Geode LX Daniel Drake
2010-10-03  5:50 ` Borislav Petkov
2010-10-03  9:26   ` Borislav Petkov
2010-10-03 14:47     ` Borislav Petkov
2010-10-03 16:32   ` Daniel Drake
2010-10-03 17:12     ` Borislav Petkov
2010-10-04 18:06     ` Steven Rostedt
2010-10-04 15:46 ` Jason Baron
2010-10-04 16:49   ` Daniel Drake
2010-10-04 20:31   ` Steven Rostedt
2010-10-04 20:39     ` Jason Baron [this message]
2010-10-04 22:11       ` Steven Rostedt
2010-10-04 21:51   ` H. Peter Anvin
2010-10-04 22:15     ` Steven Rostedt
2010-10-04 22:22       ` H. Peter Anvin
2010-10-04 22:27         ` Nick Lowe
     [not found]         ` <AANLkTikCkwF+yd4kdad8Bcz-6YX+STiy1wgrFfJxsfRg@mail.gmail.com>
2010-10-04 22:32           ` H. Peter Anvin
2010-10-26 20:08   ` Daniel Drake
2010-10-26 20:12     ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101004203921.GG2900@redhat.com \
    --to=jbaron@redhat.com \
    --cc=cjb@laptop.org \
    --cc=dilinger@queued.net \
    --cc=dsd@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.