From: Jonathan Nieder <jrnieder@gmail.com>
To: Yann Dirson <ydirson@altern.org>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Brian Ewins" <brian.ewins@gmail.com>
Subject: Re: [RFC PATCH v4 0/4] Detection of directory renames
Date: Mon, 4 Oct 2010 20:42:08 -0500 [thread overview]
Message-ID: <20101005014208.GE9994@burratino> (raw)
In-Reply-To: <1286138529-6780-1-git-send-email-ydirson@altern.org>
Yann Dirson wrote:
> The most prominent change is a
> split of the old --factorize-renames flag into --detect-dir-renames
> and --hide-dir-rename-details - hopefully following Junio's comments
> dated nearly 2 years ago.
I suspect that makes the patches more readable, too.
> I hope we can turn the simple detection feature to something
> acceptable for inclusion - that is, once unified diff output shows the
> detected renames as annotations, and once the known major holes are
> plugged (both from FIXME and testcases).
>From my point of view, I think it would be best to start with
the smallest usable piece, which is the raw format. It probably
makes the most sense to error out when -u and --detect-dir-renames are
used together. Then unified diff could be reenabled in a separate
patch series on top of this one.
Another nice feature might be to let the directory-move
detection feed back into file-move detection to make it more
accurate. Have you thought about this? Would it be feasible,
and if so, would it be useful?
next prev parent reply other threads:[~2010-10-05 1:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 20:42 [RFC PATCH v4 0/4] Detection of directory renames Yann Dirson
2010-10-03 20:42 ` [PATCH v4 1/4] Introduce wholesame directory move detection in diffcore Yann Dirson
2010-10-03 20:42 ` [PATCH v4 2/4] Add testcases for the --detect-dir-renames diffcore flag Yann Dirson
2010-10-03 20:42 ` [PATCH v4 3/4] Allow hiding renames of individual files involved in a directory rename Yann Dirson
2010-10-03 20:42 ` [PATCH v4 4/4] Add testcases for the --hide-dir-rename-details diffcore flag Yann Dirson
2010-10-03 23:04 ` Sverre Rabbelier
2010-10-03 23:06 ` [PATCH v4 3/4] Allow hiding renames of individual files involved in a directory rename Sverre Rabbelier
2010-10-03 23:28 ` Junio C Hamano
2010-10-04 6:43 ` Sverre Rabbelier
2010-10-04 18:21 ` Yann Dirson
2010-10-04 3:03 ` [PATCH v4 2/4] Add testcases for the --detect-dir-renames diffcore flag Ævar Arnfjörð Bjarmason
2010-10-04 18:32 ` Yann Dirson
2010-10-04 20:32 ` Jonathan Nieder
2010-10-04 21:37 ` Yann Dirson
2010-10-04 22:09 ` Jonathan Nieder
2010-10-05 9:21 ` Andreas Ericsson
2010-10-04 2:59 ` [PATCH v4 1/4] Introduce wholesame directory move detection in diffcore Ævar Arnfjörð Bjarmason
2010-10-04 18:19 ` Yann Dirson
2010-10-04 7:28 ` Jonathan Nieder
2010-10-04 21:13 ` Yann Dirson
2010-10-05 1:06 ` Jonathan Nieder
2010-10-06 23:13 ` Yann Dirson
2010-10-04 6:20 ` [RFC PATCH v4 0/4] Detection of directory renames Jonathan Nieder
2010-10-05 1:42 ` Jonathan Nieder [this message]
2010-10-06 23:17 ` Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005014208.GE9994@burratino \
--to=jrnieder@gmail.com \
--cc=brian.ewins@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.