From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: libxl: copy & paste bug Date: Tue, 5 Oct 2010 12:47:38 +0200 Message-ID: <201010051247.38806.Christoph.Egger@amd.com> References: <201010051205.39864.Christoph.Egger@amd.com> <1286273298.23155.7580.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_KJwqMbbz/l4V0w4" Return-path: In-Reply-To: <1286273298.23155.7580.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org --Boundary-00=_KJwqMbbz/l4V0w4 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tuesday 05 October 2010 12:08:18 Ian Campbell wrote: > On Tue, 2010-10-05 at 11:05 +0100, Christoph Egger wrote: > > Hi! > > > > In tools/libxl/libxl_bootloader.c, at the end of the > > function libxl_run_bootloader() are the following lines: > > > > if (fifo_fd > -1) > > close(fifo_fd); > > if (bootloader_fd > -1) > > close(bootloader_fd); > > if (xenconsoled_fd > -1) > > close(xenconsoled_fd); > > if (xenconsoled_slave > -1) > > close(xenconsoled_fd); > > > > The last line is wrong. It should be: > > > > close(xenconsoled_slave); > > Indeed. Please can you post a patch. Attached. Signed-off-by: Christoph Egger -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --Boundary-00=_KJwqMbbz/l4V0w4 Content-Type: text/x-diff; charset="iso 8859-15"; name="xen_libxl.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen_libxl.diff" diff -r cdff378e61eb tools/libxl/libxl_bootloader.c --- a/tools/libxl/libxl_bootloader.c Tue Oct 05 12:43:27 2010 +0200 +++ b/tools/libxl/libxl_bootloader.c Tue Oct 05 12:46:27 2010 +0200 @@ -429,7 +429,7 @@ out_close: if (xenconsoled_fd > -1) close(xenconsoled_fd); if (xenconsoled_slave > -1) - close(xenconsoled_fd); + close(xenconsoled_slave); if (fifo) { unlink(fifo); --Boundary-00=_KJwqMbbz/l4V0w4 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_KJwqMbbz/l4V0w4--