From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: hpa@zytor.com, linux-tip-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
torvalds@linux-foundation.org, ryan@innosecc.com,
tglx@linutronix.de
Subject: Re: [tip:x86/cpu] x86, cpu: Fix X86_FEATURE_NOPL
Date: Tue, 5 Oct 2010 18:53:56 +0200 [thread overview]
Message-ID: <20101005165356.GA6569@a1.tnic> (raw)
In-Reply-To: <4CAB52AD.60502@linux.intel.com>
From: "H. Peter Anvin" <hpa@linux.intel.com>
Date: Tue, Oct 05, 2010 at 09:30:37AM -0700
> On 10/5/2010 2:47 AM, Borislav Petkov wrote:
> >
> >tag it for -stable too?
> >
>
> What is the flaw that justifies it for stable, or even .36? It
> seems relatively harmless, with at most a very minor performance
> issue, unless I'm missing something?
I was thinking more along the lines of this being partially broken
when supplying non-constant arguments to cpu_has(), something like
<arch/x86/kernel/cpu/proc.c:show_cpuinfo()>, for example. But all this
could cause is /proc/cpuinfo not to report the "nopl" feature bit. I
guess this is too minor an issue to even to be considered for stable.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2010-10-05 16:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 9:37 NOPL on 32-bit Borislav Petkov
2010-10-03 14:43 ` H. Peter Anvin
2010-10-03 15:22 ` [PATCH] x86, cpu: X86_FEATURE_NOPL should be disabled on 32-bit only Borislav Petkov
2010-10-03 18:19 ` H. Peter Anvin
2010-10-03 20:11 ` Borislav Petkov
2010-10-03 22:22 ` H. Peter Anvin
2010-10-04 7:31 ` [PATCH] x86, cpu: Fix X86_FEATURE_NOPL Borislav Petkov
2010-10-04 20:36 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-10-05 9:47 ` Borislav Petkov
2010-10-05 16:30 ` H. Peter Anvin
2010-10-05 16:53 ` Borislav Petkov [this message]
2010-10-04 20:47 ` [PATCH] " Linus Torvalds
2010-10-04 21:02 ` H. Peter Anvin
2010-10-04 21:12 ` Linus Torvalds
2010-10-04 21:21 ` H. Peter Anvin
2010-10-04 21:48 ` Borislav Petkov
2010-10-04 21:50 ` H. Peter Anvin
2010-10-04 21:53 ` H. Peter Anvin
2010-10-05 6:19 ` Borislav Petkov
2010-10-04 22:17 ` Hugh Dickins
2010-10-04 22:19 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005165356.GA6569@a1.tnic \
--to=bp@alien8.de \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ryan@innosecc.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.