From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35444 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3AsA-0007Uf-Hq
	for qemu-devel@nongnu.org; Tue, 05 Oct 2010 13:00:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1P3As9-0005LI-3o
	for qemu-devel@nongnu.org; Tue, 05 Oct 2010 13:00:14 -0400
Received: from mail-ew0-f45.google.com ([209.85.215.45]:57288)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1P3As8-0005Kd-VP
	for qemu-devel@nongnu.org; Tue, 05 Oct 2010 13:00:13 -0400
Received: by ewy27 with SMTP id 27so3174365ewy.4
	for <qemu-devel@nongnu.org>; Tue, 05 Oct 2010 10:00:08 -0700 (PDT)
Date: Tue, 5 Oct 2010 19:00:03 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation
Message-ID: <20101005170003.GA12478@laped.lan>
References: <4CA6C549.9090801@runbox.com>
	<6569D071-7989-4426-9E30-7B5E80C79027@suse.de>
	<4CA762B1.7060505@runbox.com>
	<0E0E4F59-0325-44C5-9330-EB48B8A8C46F@suse.de>
	<20101002170638.GE10823@laped.lan> <4CA7772C.1090701@runbox.com>
	<79964C6A-5575-4DF7-9F3F-920E576B4460@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <79964C6A-5575-4DF7-9F3F-920E576B4460@suse.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, John Clark <clarkjc@runbox.com>

On Tue, Oct 05, 2010 at 06:42:34PM +0200, Alexander Graf wrote:
> 
> On 02.10.2010, at 20:17, John Clark wrote:
> 
> >> Hi,
> >> 
> >> Alex:
> >> I think you've missed the part of the patch that renames the _lo -> _hi.
> >> As John says, qemu had the hi/lo parts reversed when reading 4xx TLB regs.
> >> 
> >> Except for the comments and the define, the patch looks good to me.
> >> John, please also add a Signed-off-by line.
> >> 
> >> Cheers
> > 
> > Ok, I have removed the superfluous comments, added defines for magic
> > numbers, added braces to conform to the QEMU coding style guidelines,
> > and regression tested it in my system.  Patch included below.
> > 
> > Thanks.
> > 
> > - John
> > 
> > Signed-off-by: John Clark <clarkjc@runbox.com>
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Applied, thanks John and Alex.

Cheers